Commit 149b8228 authored by Patrick Noland's avatar Patrick Noland Committed by Commit Bot

Revert "[Autofill Assistant] Fix for failing tests."

This reverts commit 3e67e586.

Reason for revert: switchTabBetweenDifferentPeekModes is still failing:
https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2545

Original change's description:
> [Autofill Assistant] Fix for failing tests.
> 
> Bug: 1123958
> Change-Id: Ie0ba79cc3ace8d7a115dac30888b2430972239d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390205
> Commit-Queue: Michele Mancina <micantox@google.com>
> Reviewed-by: Marian Fechete <marianfe@google.com>
> Cr-Commit-Position: refs/heads/master@{#803874}

TBR=marianfe@google.com,micantox@google.com

Change-Id: I7811d2019d025844dd3964553ad0ca3b1086b522
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1123958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391645Reviewed-by: default avatarPatrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803981}
parent 1938e5fb
...@@ -22,7 +22,6 @@ import static org.hamcrest.Matchers.containsString; ...@@ -22,7 +22,6 @@ import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.not; import static org.hamcrest.Matchers.not;
import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntil;
import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilKeyboardMatchesCondition; import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilKeyboardMatchesCondition;
import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilViewAssertionTrue; import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilViewAssertionTrue;
import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilViewMatchesCondition; import static org.chromium.chrome.browser.autofill_assistant.AutofillAssistantUiTestUtil.waitUntilViewMatchesCondition;
...@@ -40,8 +39,8 @@ import org.junit.Rule; ...@@ -40,8 +39,8 @@ import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.task.PostTask;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.autofill_assistant.R; import org.chromium.chrome.autofill_assistant.R;
import org.chromium.chrome.browser.autofill_assistant.proto.ActionProto; import org.chromium.chrome.browser.autofill_assistant.proto.ActionProto;
...@@ -57,10 +56,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelUtils; ...@@ -57,10 +56,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.chrome.test.ChromeJUnit4ClassRunner; import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.chrome.test.ChromeTabbedActivityTestRule; import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
import org.chromium.chrome.test.util.ChromeTabUtils; import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController.SheetState;
import org.chromium.components.browser_ui.widget.scrim.ScrimCoordinator; import org.chromium.components.browser_ui.widget.scrim.ScrimCoordinator;
import org.chromium.content_public.browser.UiThreadTaskTraits;
import org.chromium.content_public.browser.test.util.TestThreadUtils; import org.chromium.content_public.browser.test.util.TestThreadUtils;
import org.chromium.net.test.EmbeddedTestServer; import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.ui.test.util.UiRestriction; import org.chromium.ui.test.util.UiRestriction;
...@@ -346,6 +342,7 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -346,6 +342,7 @@ public class AutofillAssistantChromeTabIntegrationTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "Flaky - https://crbug.com/1123958")
public void switchTabBetweenDifferentPeekModes() { public void switchTabBetweenDifferentPeekModes() {
ArrayList<ActionProto> listA = new ArrayList<>(); ArrayList<ActionProto> listA = new ArrayList<>();
listA.add((ActionProto) ActionProto.newBuilder() listA.add((ActionProto) ActionProto.newBuilder()
...@@ -370,7 +367,8 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -370,7 +367,8 @@ public class AutofillAssistantChromeTabIntegrationTest {
.proto.ChipType .proto.ChipType
.HIGHLIGHTED_ACTION))) .HIGHLIGHTED_ACTION)))
.setAllowInterrupt(false) .setAllowInterrupt(false)
.setDisableForceExpandSheet(true)) .setDisableForceExpandSheet(true)
/*.setBrowseMode(true)*/)
.build()); .build());
AutofillAssistantTestScript scriptA = new AutofillAssistantTestScript( AutofillAssistantTestScript scriptA = new AutofillAssistantTestScript(
...@@ -399,7 +397,7 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -399,7 +397,7 @@ public class AutofillAssistantChromeTabIntegrationTest {
int initialTabId = int initialTabId =
TabModelUtils.getCurrentTabId(mTestRule.getActivity().getCurrentTabModel()); TabModelUtils.getCurrentTabId(mTestRule.getActivity().getCurrentTabModel());
setupScripts(scriptA, scriptB); AutofillAssistantTestService autofillAssistantTestService = setupScripts(scriptA, scriptB);
startAutofillAssistantOnTab(TEST_PAGE_A); startAutofillAssistantOnTab(TEST_PAGE_A);
waitUntilViewMatchesCondition( waitUntilViewMatchesCondition(
allOf(withText("Sticky"), isDescendantOfA(withId(R.id.header))), allOf(withText("Sticky"), isDescendantOfA(withId(R.id.header))),
...@@ -412,13 +410,11 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -412,13 +410,11 @@ public class AutofillAssistantChromeTabIntegrationTest {
startAutofillAssistantOnTab(TEST_PAGE_B); startAutofillAssistantOnTab(TEST_PAGE_B);
waitUntilViewMatchesCondition(withText("Prompt B"), isCompletelyDisplayed()); waitUntilViewMatchesCondition(withText("Prompt B"), isCompletelyDisplayed());
waitForBottomSheetAnimationToEnd();
Espresso.pressBack(); Espresso.pressBack();
waitUntilViewMatchesCondition( waitUntilViewMatchesCondition(
withId(R.id.status_message), allOf(withText("Prompt B"), not(isDisplayed()))); withId(R.id.status_message), allOf(withText("Prompt B"), not(isDisplayed())));
onView(withId(R.id.autofill_assistant)).check(matches(isDisplayed())); onView(withId(R.id.autofill_assistant)).check(matches(isDisplayed()));
waitForBottomSheetAnimationToEnd();
int secondTabId = int secondTabId =
TabModelUtils.getCurrentTabId(mTestRule.getActivity().getCurrentTabModel()); TabModelUtils.getCurrentTabId(mTestRule.getActivity().getCurrentTabModel());
...@@ -430,18 +426,18 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -430,18 +426,18 @@ public class AutofillAssistantChromeTabIntegrationTest {
waitUntilViewMatchesCondition( waitUntilViewMatchesCondition(
allOf(withText("Sticky"), isDescendantOfA(withId(R.id.header))), allOf(withText("Sticky"), isDescendantOfA(withId(R.id.header))),
isCompletelyDisplayed()); isCompletelyDisplayed());
PostTask.postTask(UiThreadTaskTraits.DEFAULT, () -> {
ChromeTabUtils.switchTabInCurrentTabModel(mTestRule.getActivity(), ChromeTabUtils.switchTabInCurrentTabModel(mTestRule.getActivity(),
TabModelUtils.getTabIndexById( TabModelUtils.getTabIndexById(
mTestRule.getActivity().getCurrentTabModel(), secondTabId)); mTestRule.getActivity().getCurrentTabModel(), secondTabId));
waitUntilViewMatchesCondition(withId(R.id.autofill_assistant), isDisplayed()); waitUntilViewMatchesCondition(withId(R.id.autofill_assistant), isDisplayed());
waitUntilViewMatchesCondition( onView(allOf(withId(R.id.status_message), withText("Prompt B")))
allOf(withId(R.id.status_message), withText("Prompt B")), not(isDisplayed())); .check(matches(not(isDisplayed())));
});
} }
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "Flaky - https://crbug.com/1115681")
public void startingNewAutofillAssistantCloseTabResumesRunOnPreviousTab() { public void startingNewAutofillAssistantCloseTabResumesRunOnPreviousTab() {
ArrayList<ActionProto> listA = new ArrayList<>(); ArrayList<ActionProto> listA = new ArrayList<>();
listA.add((ActionProto) ActionProto.newBuilder() listA.add((ActionProto) ActionProto.newBuilder()
...@@ -476,7 +472,6 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -476,7 +472,6 @@ public class AutofillAssistantChromeTabIntegrationTest {
startAutofillAssistantOnTab(TEST_PAGE_A); startAutofillAssistantOnTab(TEST_PAGE_A);
waitUntilViewMatchesCondition(withText("Prompt A"), isCompletelyDisplayed()); waitUntilViewMatchesCondition(withText("Prompt A"), isCompletelyDisplayed());
waitForBottomSheetAnimationToEnd();
ChromeTabUtils.fullyLoadUrlInNewTab(InstrumentationRegistry.getInstrumentation(), ChromeTabUtils.fullyLoadUrlInNewTab(InstrumentationRegistry.getInstrumentation(),
mTestRule.getActivity(), getURL(TEST_PAGE_B), false); mTestRule.getActivity(), getURL(TEST_PAGE_B), false);
...@@ -484,7 +479,6 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -484,7 +479,6 @@ public class AutofillAssistantChromeTabIntegrationTest {
startAutofillAssistantOnTab(TEST_PAGE_B); startAutofillAssistantOnTab(TEST_PAGE_B);
waitUntilViewMatchesCondition(withText("Prompt B"), isCompletelyDisplayed()); waitUntilViewMatchesCondition(withText("Prompt B"), isCompletelyDisplayed());
waitForBottomSheetAnimationToEnd();
ChromeTabUtils.closeCurrentTab( ChromeTabUtils.closeCurrentTab(
InstrumentationRegistry.getInstrumentation(), mTestRule.getActivity()); InstrumentationRegistry.getInstrumentation(), mTestRule.getActivity());
...@@ -492,10 +486,6 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -492,10 +486,6 @@ public class AutofillAssistantChromeTabIntegrationTest {
waitUntilViewMatchesCondition(withText("Prompt A"), isCompletelyDisplayed()); waitUntilViewMatchesCondition(withText("Prompt A"), isCompletelyDisplayed());
} }
private void waitForBottomSheetAnimationToEnd() {
waitUntil(() -> getBottomSheetController().getSheetState() != SheetState.SCROLLING);
}
@Test @Test
@MediumTest @MediumTest
public void interactingWithLocationBarHidesAutofillAssistant() { public void interactingWithLocationBarHidesAutofillAssistant() {
...@@ -562,8 +552,4 @@ public class AutofillAssistantChromeTabIntegrationTest { ...@@ -562,8 +552,4 @@ public class AutofillAssistantChromeTabIntegrationTest {
InstrumentationRegistry.getInstrumentation(), mTestRule.getActivity()); InstrumentationRegistry.getInstrumentation(), mTestRule.getActivity());
waitUntilViewMatchesCondition(withText("Shutdown"), isCompletelyDisplayed()); waitUntilViewMatchesCondition(withText("Shutdown"), isCompletelyDisplayed());
} }
private BottomSheetController getBottomSheetController() {
return mTestRule.getActivity().getRootUiCoordinatorForTesting().getBottomSheetController();
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment