Move HTMLSelectElement::SelectAll() to SelectType

This CL has no behavior changes.

Bug: 1052232
Change-Id: I9b583888cea7708a69eb35ac89c2dca2938f74b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066405Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743420}

third_party/blink/renderer/core/html/forms/html_select_element.cc

@@ -567,21 +567,7 @@ HTMLOptionElement* HTMLSelectElement::NextSelectableOptionPageAway(
 }
 
 void HTMLSelectElement::SelectAll() {
-  DCHECK(!UsesMenuList());
-  if (!GetLayoutObject() || !is_multiple_)
-    return;
-
-  // Save the selection so it can be compared to the new selectAll selection
-  // when dispatching change events.
-  SaveLastSelection();
-
-  active_selection_state_ = true;
-  SetActiveSelectionAnchor(NextSelectableOption(nullptr));
-  SetActiveSelectionEnd(PreviousSelectableOption(nullptr));
-
-  UpdateListBoxSelection(false, false);
-  ListBoxOnChange();
-  SetNeedsValidityCheck();
+  select_type_->SelectAll();
 }
 
 void HTMLSelectElement::SaveLastSelection() {

third_party/blink/renderer/core/html/forms/select_type.cc

@@ -383,6 +383,7 @@ class ListBoxSelectType final : public SelectType {
   explicit ListBoxSelectType(HTMLSelectElement& select) : SelectType(select) {}
   bool DefaultEventHandler(const Event& event) override;
   void UpdateMultiSelectFocus() override;
+  void SelectAll() override;
 
  private:
   bool is_in_non_contiguous_selection_ = false;
@@ -654,6 +655,23 @@ void ListBoxSelectType::UpdateMultiSelectFocus() {
   select_->ScrollToSelection();
 }
 
+void ListBoxSelectType::SelectAll() {
+  if (!select_->GetLayoutObject() || !select_->is_multiple_)
+    return;
+
+  // Save the selection so it can be compared to the new selectAll selection
+  // when dispatching change events.
+  select_->SaveLastSelection();
+
+  select_->active_selection_state_ = true;
+  select_->SetActiveSelectionAnchor(select_->NextSelectableOption(nullptr));
+  select_->SetActiveSelectionEnd(select_->PreviousSelectableOption(nullptr));
+
+  select_->UpdateListBoxSelection(false, false);
+  select_->ListBoxOnChange();
+  select_->SetNeedsValidityCheck();
+}
+
 // ============================================================================
 
 SelectType::SelectType(HTMLSelectElement& select) : select_(select) {}
@@ -691,4 +709,8 @@ const ComputedStyle* SelectType::OptionStyle() const {
 
 void SelectType::UpdateMultiSelectFocus() {}
 
+void SelectType::SelectAll() {
+  NOTREACHED();
+}
+
 }  // namespace blink

third_party/blink/renderer/core/html/forms/select_type.h

@@ -39,6 +39,8 @@ class SelectType : public GarbageCollected<SelectType> {
   // Update :-internal-multi-select-focus state of selected OPTIONs.
   virtual void UpdateMultiSelectFocus();
 
+  virtual void SelectAll();
+
   // TODO(crbug.com/1052232): Add more virtual functions.
 
  protected: