Commit 14ee9448 authored by Yulun Wu's avatar Yulun Wu Committed by Commit Bot

This CL needs to be reverted because it will impact the way Marketing parses...

This CL needs to be reverted because it will impact the way Marketing parses arguments. Ignoring board name from Query URL will happen server side.

Revert "Remove board name from Release Notes query URL."

This reverts commit 412a7947.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove board name from Release Notes query URL.
> 
> Bug: 1068756
> Change-Id: I68fa01f5e16fac4d981b1d26fab6f2d6ba94e7e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141127
> Commit-Queue: Yulun Wu <yulunwu@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757345}

TBR=ellyjones@chromium.org,pkasting@chromium.org,yulunwu@chromium.org

Change-Id: I8af156038f43ede0d26e6c284298f20e4ba5c619
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142720Reviewed-by: default avatarYulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757669}
parent a70b3f9f
......@@ -16,6 +16,7 @@
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/system/sys_info.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "chrome/browser/apps/app_service/app_launch_params.h"
......@@ -109,6 +110,7 @@ void OpenBookmarkManagerForNode(Browser* browser, int64_t node_id) {
#if defined(OS_CHROMEOS) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
const std::string BuildQueryString(Profile* profile) {
const std::string board_name = base::SysInfo::GetLsbReleaseBoard();
std::string region;
chromeos::system::StatisticsProvider::GetInstance()->GetMachineStatistic(
"region", &region);
......@@ -131,8 +133,8 @@ const std::string BuildQueryString(Profile* profile) {
}
const std::string query_string = base::StrCat(
{kChromeReleaseNotesURL, "?version=", milestone, "&tags=", region, ",",
language, ",", channel_name, ",", user_type});
{kChromeReleaseNotesURL, "?version=", milestone, "&tags=", board_name,
",", region, ",", language, ",", channel_name, ",", user_type});
return query_string;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment