Commit 150b7e56 authored by peria's avatar peria Committed by Commit bot

Do not install document into hidden Window object, i.e. inner global Window.

Now we keep document in LocalDOMWindow, and do not have to keep it alive in hidden window object.

BUG=None

Review URL: https://codereview.chromium.org/1836193002

Cr-Commit-Position: refs/heads/master@{#383912}
parent f16fa0a4
......@@ -33,7 +33,6 @@ class ScriptWrappable;
V(condition) \
V(data) \
V(detail) \
V(document) \
V(error) \
V(event) \
V(idbCursorRequest) \
......
......@@ -431,11 +431,6 @@ void WindowProxy::updateDocumentProperty()
// TODO(jochen): Don't replace the accessor with a data value. We need a way to tell v8 that the accessor's return value won't change after this point.
if (!v8CallBoolean(context->Global()->ForceSet(context, v8AtomicString(m_isolate, "document"), documentWrapper, static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete))))
return;
// We also stash a reference to the document on the inner global object so that
// LocalDOMWindow objects we obtain from JavaScript references are guaranteed to have
// live Document objects.
V8HiddenValue::setHiddenValue(m_scriptState.get(), toInnerGlobalObject(context), V8HiddenValue::document(m_isolate), documentWrapper);
}
void WindowProxy::updateActivityLogger()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment