Commit 150c405c authored by Eric Karl's avatar Eric Karl Committed by Commit Bot

Disable Surface Synchronization for DualBrowserStorySet's WebView

DualBrowserStorySet uses non-standard set-up to create its webview,
missing the previous option customization added to PerfBenchmark's
CustomizeBrowserOptions. While this should probably be unified,
copying the relevant options over for now to un-break the dual browser
case.

Also disables VizDisplayCompositor, as this is a related unsupported
feature, and although things happen to work now, we don't want to rely
on that.

Bug: 881469
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I1070210c2a92768795689d4488369c0b589ca9bb
Reviewed-on: https://chromium-review.googlesource.com/1236468
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#593312}
parent 951a2271
...@@ -108,10 +108,10 @@ class PerfBenchmark(benchmark.Benchmark): ...@@ -108,10 +108,10 @@ class PerfBenchmark(benchmark.Benchmark):
# TODO(crbug.com/881469): remove this once Webview support surface # TODO(crbug.com/881469): remove this once Webview support surface
# synchronization. # synchronization and viz.
if options.browser_type and 'android-webview' in options.browser_type: if options.browser_type and 'android-webview' in options.browser_type:
options.AppendExtraBrowserArgs( options.AppendExtraBrowserArgs(
'--disable-features=SurfaceSynchronization') '--disable-features=SurfaceSynchronization,VizDisplayCompositor')
self.SetExtraBrowserOptions(options) self.SetExtraBrowserOptions(options)
@staticmethod @staticmethod
......
...@@ -45,6 +45,13 @@ def _OptionsForBrowser(browser_type, finder_options): ...@@ -45,6 +45,13 @@ def _OptionsForBrowser(browser_type, finder_options):
finder_options.browser_type = browser_type finder_options.browser_type = browser_type
finder_options.browser_executable = None finder_options.browser_executable = None
finder_options.browser_options.browser_type = browser_type finder_options.browser_options.browser_type = browser_type
# TODO(crbug.com/881469): remove this once Webview support surface
# synchronization and viz.
if browser_type and 'android-webview' in browser_type:
finder_options.browser_options.AppendExtraBrowserArgs(
'--disable-features=SurfaceSynchronization,VizDisplayCompositor')
return finder_options return finder_options
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment