Commit 153fceee authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/url_formatter

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I059cda5bed6712f503f3b9c41108ff365d4eb797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414296
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807547}
parent 4062808b
......@@ -6,6 +6,12 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("skeleton_generator") {
sources = [
"spoof_checks/skeleton_generator.cc",
......@@ -27,7 +33,6 @@ static_library("url_formatter") {
"url_fixer.h",
"url_formatter.cc",
"url_formatter.h",
"url_formatter_android.cc",
]
configs += [
......@@ -54,6 +59,7 @@ static_library("url_formatter") {
public_deps = [ "//third_party/icu" ]
if (is_android) {
sources += [ "url_formatter_android.cc" ]
deps += [
"android:jni_headers",
"//url:gurl_android",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment