Commit 1544cd09 authored by Kevin Bailey's avatar Kevin Bailey Committed by Commit Bot

[omnibox] Use more MakeUnique

Convert some bare new()s and a theoretical memory leak into
MakeUnique's.

Bug: 
Change-Id: I1e80714c42f2d7575e774ffdbe2b8f2d5c83c6de
Reviewed-on: https://chromium-review.googlesource.com/801350
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520801}
parent 69ff8007
...@@ -39,12 +39,14 @@ AutocompleteClassifierFactory* AutocompleteClassifierFactory::GetInstance() { ...@@ -39,12 +39,14 @@ AutocompleteClassifierFactory* AutocompleteClassifierFactory::GetInstance() {
std::unique_ptr<KeyedService> AutocompleteClassifierFactory::BuildInstanceFor( std::unique_ptr<KeyedService> AutocompleteClassifierFactory::BuildInstanceFor(
content::BrowserContext* context) { content::BrowserContext* context) {
Profile* profile = static_cast<Profile*>(context); Profile* profile = static_cast<Profile*>(context);
auto provider_client =
base::MakeUnique<ChromeAutocompleteProviderClient>(profile);
auto controller = base::WrapUnique(new AutocompleteController(
std::move(provider_client), NULL,
AutocompleteClassifier::DefaultOmniboxProviders()));
return base::MakeUnique<AutocompleteClassifier>( return base::MakeUnique<AutocompleteClassifier>(
base::WrapUnique(new AutocompleteController( std::move(controller),
base::WrapUnique(new ChromeAutocompleteProviderClient(profile)), NULL, base::MakeUnique<ChromeAutocompleteSchemeClassifier>(profile));
AutocompleteClassifier::DefaultOmniboxProviders())),
std::unique_ptr<AutocompleteSchemeClassifier>(
new ChromeAutocompleteSchemeClassifier(profile)));
} }
AutocompleteClassifierFactory::AutocompleteClassifierFactory() AutocompleteClassifierFactory::AutocompleteClassifierFactory()
......
...@@ -1000,8 +1000,8 @@ TEST_F(SearchProviderTest, KeywordOrderingAndDescriptions) { ...@@ -1000,8 +1000,8 @@ TEST_F(SearchProviderTest, KeywordOrderingAndDescriptions) {
profile_.BlockUntilHistoryProcessesPendingRequests(); profile_.BlockUntilHistoryProcessesPendingRequests();
AutocompleteController controller( AutocompleteController controller(
base::WrapUnique(new ChromeAutocompleteProviderClient(&profile_)), base::MakeUnique<ChromeAutocompleteProviderClient>(&profile_), nullptr,
nullptr, AutocompleteProvider::TYPE_SEARCH); AutocompleteProvider::TYPE_SEARCH);
AutocompleteInput input(ASCIIToUTF16("k t"), AutocompleteInput input(ASCIIToUTF16("k t"),
metrics::OmniboxEventProto::OTHER, metrics::OmniboxEventProto::OTHER,
ChromeAutocompleteSchemeClassifier(&profile_)); ChromeAutocompleteSchemeClassifier(&profile_));
......
...@@ -195,7 +195,7 @@ SuggestionAnswer::~SuggestionAnswer() {} ...@@ -195,7 +195,7 @@ SuggestionAnswer::~SuggestionAnswer() {}
// static // static
std::unique_ptr<SuggestionAnswer> SuggestionAnswer::ParseAnswer( std::unique_ptr<SuggestionAnswer> SuggestionAnswer::ParseAnswer(
const base::DictionaryValue* answer_json) { const base::DictionaryValue* answer_json) {
auto result = base::WrapUnique(new SuggestionAnswer); auto result = base::MakeUnique<SuggestionAnswer>();
const base::ListValue* lines_json; const base::ListValue* lines_json;
if (!answer_json->GetList(kAnswerJsonLines, &lines_json) || if (!answer_json->GetList(kAnswerJsonLines, &lines_json) ||
......
...@@ -35,7 +35,7 @@ TEST(SuggestionAnswerTest, CopiesAreEqual) { ...@@ -35,7 +35,7 @@ TEST(SuggestionAnswerTest, CopiesAreEqual) {
SuggestionAnswer answer1; SuggestionAnswer answer1;
EXPECT_TRUE(answer1.Equals(SuggestionAnswer(answer1))); EXPECT_TRUE(answer1.Equals(SuggestionAnswer(answer1)));
auto answer2 = base::WrapUnique(new SuggestionAnswer); auto answer2 = base::MakeUnique<SuggestionAnswer>();
answer2->set_type(832345); answer2->set_type(832345);
EXPECT_TRUE(answer2->Equals(SuggestionAnswer(*answer2))); EXPECT_TRUE(answer2->Equals(SuggestionAnswer(*answer2)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment