Commit 1575900e authored by Vaclav Brozek's avatar Vaclav Brozek Committed by Commit Bot

Remove TODOs for bug 159166

The bug tracked adding viewing of passwords to iOS settings. There
were two remaining TODOs:
* An outdated comment in a test.
* A refactoring suggestion for trading off code complexity for test
  complexity (add a delegate API to make a particular EG test a unit
  test).

The refactoring suggestion does not seem justified -- the current EG
tests are stable and working well.

Therefore this CL removes both TODOs.

Bug: 159166
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I20658b94b4fa190a2ffa442af6f9f7b4ec1aeed4
Reviewed-on: https://chromium-review.googlesource.com/892818Reviewed-by: default avatarEric Noyau <noyau@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533251}
parent 9d8b6159
......@@ -480,8 +480,6 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule {
// Show a MD snack bar with |message| and provide haptic feedback. The haptic
// feedback is either for success or for error, depending on |success|.
- (void)showToast:(NSString*)message forSuccess:(BOOL)success {
// TODO(crbug.com/159166): Route this through some delegate API to be able
// to mock it in the unittest, and avoid having an EGTest just for that?
TriggerHapticFeedbackForNotification(success
? UINotificationFeedbackTypeSuccess
: UINotificationFeedbackTypeError);
......
......@@ -47,9 +47,6 @@
// password_details_collection_view_controller_unittest.mm. Very simple
// integration tests and features which are not currently unittestable should
// go here, the rest into the unittest.
// This test only uses the new UI which allows viewing passwords.
// TODO(crbug.com/159166): Remove the above sentence once the new UI is the
// default one.
using autofill::PasswordForm;
using chrome_test_util::ButtonWithAccessibilityLabel;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment