Commit 15765a02 authored by Jack Lynch's avatar Jack Lynch Committed by Commit Bot

DevTools: Instrument all actions for shortcut telemetry

This CL adds all of the existing DevTools actions to the
DevToolsKeyboardShortcutAction enum so that we'll get a clearer picture
of which shortcuts are being used. The corresponding frontend enum is
updated in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2276745

Custom shortcuts design doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit#

Bug: 174309
Change-Id: I203bc9364c571685f92b770e6de7bcf0ebc7e0ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276498
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: default avatarBrandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#784237}
parent 0e0e4a77
...@@ -15915,6 +15915,75 @@ to ensure that the crash string is shown properly on the user-facing crash UI. ...@@ -15915,6 +15915,75 @@ to ensure that the crash string is shown properly on the user-facing crash UI.
<int value="21" label="quickOpen.show"/> <int value="21" label="quickOpen.show"/>
<int value="22" label="settings.show"/> <int value="22" label="settings.show"/>
<int value="23" label="sources.search"/> <int value="23" label="sources.search"/>
<int value="24" label="background-service.toggle-recording"/>
<int value="25" label="components.collect-garbage"/>
<int value="26" label="console.clear.history"/>
<int value="27" label="console.create-pin"/>
<int value="28" label="coverage.start-with-reload"/>
<int value="29" label="coverage.toggle-recording"/>
<int value="30" label="debugger.breakpoint-input-window"/>
<int value="31" label="debugger.evaluate-selection"/>
<int value="32" label="debugger.next-call-frame"/>
<int value="33" label="debugger.previous-call-frame"/>
<int value="34" label="debugger.run-snippet"/>
<int value="35" label="debugger.toggle-breakpoints-active"/>
<int value="36" label="elements.capture-area-screenshot"/>
<int value="37" label="emulation.capture-full-height-screenshot"/>
<int value="38" label="emulation.capture-node-screenshot"/>
<int value="39" label="emulation.capture-screenshot"/>
<int value="40" label="emulation.show-sensors"/>
<int value="41" label="emulation.toggle-device-mode"/>
<int value="42" label="help.release-notes"/>
<int value="43" label="help.report-issue"/>
<int value="44" label="input.start-replaying"/>
<int value="45" label="input.toggle-pause"/>
<int value="46" label="input.toggle-recording"/>
<int value="47" label="inspector_main.focus-debuggee"/>
<int value="48" label="inspector_main.hard-reload"/>
<int value="49" label="inspector_main.reload"/>
<int value="50" label="live-heap-profile.start-with-reload"/>
<int value="51" label="live-heap-profile.toggle-recording"/>
<int value="52" label="main.debug-reload"/>
<int value="53" label="main.next-tab"/>
<int value="54" label="main.previous-tab"/>
<int value="55" label="main.search-in-panel.cancel"/>
<int value="56" label="main.search-in-panel.find-next"/>
<int value="57" label="main.search-in-panel.find-previous"/>
<int value="58" label="main.toggle-dock"/>
<int value="59" label="main.zoom-in"/>
<int value="60" label="main.zoom-out"/>
<int value="61" label="main.zoom-reset"/>
<int value="62" label="network-conditions.network-low-end-mobile"/>
<int value="63" label="network-conditions.network-mid-tier-mobile"/>
<int value="64" label="network-conditions.network-offline"/>
<int value="65" label="network-conditions.network-online"/>
<int value="66" label="profiler.heap-toggle-recording"/>
<int value="67" label="profiler.js-toggle-recording"/>
<int value="68" label="resources.clear"/>
<int value="69" label="settings.documentation"/>
<int value="70" label="settings.shortcuts"/>
<int value="71" label="sources.add-folder-to-workspace"/>
<int value="72" label="sources.add-to-watch"/>
<int value="73" label="sources.close-all"/>
<int value="74" label="sources.close-editor-tab"/>
<int value="75" label="sources.create-snippet"/>
<int value="76" label="sources.go-to-line"/>
<int value="77" label="sources.go-to-member"/>
<int value="78" label="sources.jump-to-next-location"/>
<int value="79" label="sources.jump-to-previous-location"/>
<int value="80" label="sources.rename"/>
<int value="81" label="sources.save"/>
<int value="82" label="sources.save-all"/>
<int value="83" label="sources.switch-file"/>
<int value="84" label="timeline.jump-to-next-frame"/>
<int value="85" label="timeline.jump-to-previous-frame"/>
<int value="86" label="timeline.load-from-file"/>
<int value="87" label="timeline.next-recording"/>
<int value="88" label="timeline.previous-recording"/>
<int value="89" label="timeline.record-reload"/>
<int value="90" label="timeline.save-to-file"/>
<int value="91" label="timeline.show-history"/>
<int value="92" label="timeline.toggle-recording"/>
</enum> </enum>
<enum name="DevToolsPanel"> <enum name="DevToolsPanel">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment