Commit 158cc5cd authored by meacer's avatar meacer Committed by Commit bot

Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the
data URLs in these tests to HTTP urls, but doing that causes the tests to
fail more often -- they start to fail on Windows. I investigated the
failures and can't see a good way of fixing them
(https://crbug.com/703727#c8) so I'm disabling them in the meanwhile.

BUG=594215

Review-Url: https://codereview.chromium.org/2803813002
Cr-Commit-Position: refs/heads/master@{#462948}
parent 04b9338b
......@@ -1433,17 +1433,10 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestExecuteScript) {
TestHelper("testExecuteScript", "web_view/shim", NO_TEST_SERVER);
}
// Flaky on Linux. See https://crbug.com/703727.
#if defined(OS_LINUX)
#define MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
DISABLED_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
#else
#define MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
#endif
// Flaky and likely not testing the right assertion. https://crbug.com/703727
IN_PROC_BROWSER_TEST_P(
WebViewTest,
MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
DISABLED_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
TestHelper("testExecuteScriptIsAbortedWhenWebViewSourceIsChanged",
"web_view/shim",
NO_TEST_SERVER);
......
......@@ -533,17 +533,10 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestExecuteScriptFail) {
RunTest("testExecuteScriptFail", "web_view/apitest");
}
// Failes on Linux/CrOS. https://crbug.com/702918
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
#define MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
DISABLED_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
#else
#define MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
#endif
// Flaky and likely not testing the right assertion. https://crbug.com/702918
IN_PROC_BROWSER_TEST_F(
WebViewAPITest,
MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
DISABLED_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
RunTest("testExecuteScriptIsAbortedWhenWebViewSourceIsChanged",
"web_view/apitest");
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment