Commit 15bbc817 authored by Matthias Körber's avatar Matthias Körber Committed by Commit Bot

Removed unused methods from |BrowserSavePasswordProgressLogger|.

Change-Id: Ifc488d87f8e827cc8a34252a8011375ea24dbb33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824270
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699746}
parent b18f65f7
......@@ -100,26 +100,6 @@ BrowserSavePasswordProgressLogger::BrowserSavePasswordProgressLogger(
BrowserSavePasswordProgressLogger::~BrowserSavePasswordProgressLogger() {}
void BrowserSavePasswordProgressLogger::LogFormSignatures(
SavePasswordProgressLogger::StringID label,
const autofill::PasswordForm& form) {
FormStructure form_structure(form.form_data);
std::string message = GetStringFromID(label) + ": {\n";
message += GetStringFromID(STRING_FORM_SIGNATURE) + ": " +
FormSignatureToDebugString(form_structure.form_signature()) + "\n";
message += GetStringFromID(STRING_SIGNON_REALM) + ": " +
ScrubURL(GURL(form.signon_realm)) + "\n";
message +=
GetStringFromID(STRING_ORIGIN) + ": " + ScrubURL(form.origin) + "\n";
message +=
GetStringFromID(STRING_ACTION) + ": " + ScrubURL(form.action) + "\n";
message += GetStringFromID(STRING_FORM_NAME) + ": " +
ScrubElementID(form.form_data.name) + "\n";
message += FormStructureToFieldsLogString(form_structure);
message += "}";
SendLog(message);
}
void BrowserSavePasswordProgressLogger::LogFormStructure(
StringID label,
const FormStructure& form_structure) {
......
......@@ -30,10 +30,6 @@ class BrowserSavePasswordProgressLogger
const autofill::LogManager* log_manager);
~BrowserSavePasswordProgressLogger() override;
// Browser-specific addition to the base class' Log* methods. The input is
// sanitized and passed to SendLog for display.
void LogFormSignatures(StringID label, const autofill::PasswordForm& form);
// Browser-specific addition to the base class' Log* methods. The input is
// sanitized and passed to SendLog for display.
void LogFormStructure(StringID label, const autofill::FormStructure& form);
......
......@@ -76,41 +76,6 @@ class BrowserSavePasswordProgressLoggerTest : public testing::Test {
} // namespace
TEST_F(BrowserSavePasswordProgressLoggerTest, LogFormSignatures) {
MockLogManager log_manager;
TestLogger logger(&log_manager);
autofill::FormStructure form_structure(form_);
// Add a vote, a generation event and a client-side classifier outcome to the
// password field.
autofill::ServerFieldTypeSet type_set;
type_set.insert(autofill::NEW_PASSWORD);
form_structure.field(0)->set_possible_types(type_set);
form_structure.field(0)->set_generation_type(
autofill::AutofillUploadContents::Field::
MANUALLY_TRIGGERED_GENERATION_ON_SIGN_UP_FORM);
// Add a server prediction for the text field.
form_structure.field(1)->set_server_type(autofill::EMAIL_ADDRESS);
logger.LogFormStructure(Logger::STRING_PASSWORD_FORM_VOTE, form_structure);
SCOPED_TRACE(testing::Message() << "Log string = ["
<< logger.accumulated_log() << "]");
EXPECT_TRUE(logger.LogsContainSubstring("PasswordForm vote: {"));
EXPECT_TRUE(logger.LogsContainSubstring("Signature of form"));
EXPECT_TRUE(logger.LogsContainSubstring("Origin: http://myform.com"));
EXPECT_TRUE(logger.LogsContainSubstring("Form fields:"));
EXPECT_TRUE(logger.LogsContainSubstring(
"password: 2051817934, type=password, renderer_id = 10, "
"autocomplete=new-password, VOTE: "
"NEW_PASSWORD, GENERATION_EVENT: "
"Manual generation on sign-up"));
EXPECT_TRUE(
logger.LogsContainSubstring("email: 420638584, type=text, renderer_id = "
"42, SERVER_PREDICTION: EMAIL_ADDRESS"));
}
TEST_F(BrowserSavePasswordProgressLoggerTest, LogFormData) {
MockLogManager log_manager;
TestLogger logger(&log_manager);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment