Commit 15bd2351 authored by Abhijeet Kandalkar's avatar Abhijeet Kandalkar Committed by Commit Bot

Regression: Broken extensions page toggle button handling

After clicking the toggle button to enable/disable the extension, the
icon of the next extension is getting selected. This issue is a
regression from[1].

[1] https://crrev.com/c/1567561

Bug: 1060114
Change-Id: I14c4f713e6819267724baec6d9cbdcba7de74f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133986Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755857}
parent 283079bc
......@@ -71,8 +71,9 @@ const LayoutBlockFlow& RootInlineContentsContainerOf(
for (const LayoutBlock* runner = block_flow.ContainingBlock(); runner;
runner = runner->ContainingBlock()) {
auto* containing_block_flow = DynamicTo<LayoutBlockFlow>(runner);
if (containing_block_flow && runner->ChildrenInline())
root_block_flow = containing_block_flow;
if (!containing_block_flow || !runner->ChildrenInline())
break;
root_block_flow = containing_block_flow;
}
DCHECK(!root_block_flow->IsAtomicInlineLevel())
<< block_flow << ' ' << root_block_flow;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment