Commit 15c17966 authored by mgiuca@chromium.org's avatar mgiuca@chromium.org

Helpful message for not checking SupportsMultipleDisplays on Win7 tests.

"Multiple display test does not work on Windows bots. Please skip (don't
disable) the test using SupportsMultipleDisplays()"

Previously, this message only showed on Windows 8 if you forget to check
SupportsMultipleDisplays in a test with multiple displays. Now it shows
on Windows 7 as well.

Without this message, you get a much more confusing crash.

BUG=370796

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268933

Review URL: https://codereview.chromium.org/270253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269700 0039d316-1c4b-4281-b951-d872f2087c98
parent 0bf04c1f
...@@ -632,11 +632,9 @@ void DisplayManager::UpdateDisplays() { ...@@ -632,11 +632,9 @@ void DisplayManager::UpdateDisplays() {
void DisplayManager::UpdateDisplays( void DisplayManager::UpdateDisplays(
const std::vector<DisplayInfo>& updated_display_info_list) { const std::vector<DisplayInfo>& updated_display_info_list) {
#if defined(OS_WIN) #if defined(OS_WIN)
if (base::win::GetVersion() >= base::win::VERSION_WIN8) { DCHECK_EQ(1u, updated_display_info_list.size()) <<
DCHECK_EQ(1u, updated_display_info_list.size()) << ": Multiple display test does not work on Windows bots. Please "
"Multiple display test does not work on Win8 bots. Please " "skip (don't disable) the test using SupportsMultipleDisplays()";
"skip (don't disable) the test using SupportsMultipleDisplays()";
}
#endif #endif
DisplayInfoList new_display_info_list = updated_display_info_list; DisplayInfoList new_display_info_list = updated_display_info_list;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment