Commit 15c1a67f authored by Michael Checo's avatar Michael Checo Committed by Commit Bot

Diagnostics: Use localized strings in data point titles

Screenshots:
 - Diagnostics App (before) http://shortn/_UuPjDwlNnn
 - Diagnostics App (after) http://shortn/_4Aem4oahU9

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Id15c38b3453ca77dabd8e215cd5dbd1d6a94418d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441680Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/master@{#814476}
parent 6912cdb0
...@@ -8,25 +8,26 @@ ...@@ -8,25 +8,26 @@
value="[[batteryChargeStatus_.charge_now_milliamp_hours]]" value="[[batteryChargeStatus_.charge_now_milliamp_hours]]"
max="[[batteryChargeStatus_.charge_full_now_milliamp_hours]]"> max="[[batteryChargeStatus_.charge_full_now_milliamp_hours]]">
</percent-bar-chart> </percent-bar-chart>
<data-point slot="body" id="currentNow" <data-point slot="body" id="currentNow" header="[[i18n('currentNow')]]"
value="[[batteryChargeStatus_.current_now_milliamps]]"> value="[[batteryChargeStatus_.current_now_milliamps]]">
</data-point> </data-point>
<data-point slot="body" id="chargeFullDesign" <data-point slot="body" id="chargeFullDesign"
header="[[i18n('chargeFullDesign')]]"
value="[[batteryHealth_.charge_full_design_milliamp_hours]]"> value="[[batteryHealth_.charge_full_design_milliamp_hours]]">
</data-point> </data-point>
<data-point slot="body" id="chargeFullNow" <data-point slot="body" id="chargeFullNow" header="[[i18n('chargeFullNow')]]"
value="[[batteryChargeStatus_.charge_full_now_milliamp_hours]]"> value="[[batteryChargeStatus_.charge_full_now_milliamp_hours]]">
</data-point> </data-point>
<data-point slot="body" id="chargeNow" <data-point slot="body" id="chargeNow" header="[[i18n('chargeNow')]]"
value="[[batteryChargeStatus_.charge_now_milliamp_hours]]"> value="[[batteryChargeStatus_.charge_now_milliamp_hours]]">
</data-point> </data-point>
<data-point slot="body" id="powerTime" <data-point slot="body" id="powerTime" header="[[i18n('powerTime')]]"
value="[[batteryChargeStatus_.power_time]]"> value="[[batteryChargeStatus_.power_time]]">
</data-point> </data-point>
<data-point slot="body" id="adapterStatus" <data-point slot="body" id="adapterStatus" header="[[i18n('adapterStatus')]]"
value="[[batteryChargeStatus_.power_adapter_status]]"> value="[[batteryChargeStatus_.power_adapter_status]]">
</data-point> </data-point>
<data-point slot="body" id="cycleCount" <data-point slot="body" id="cycleCount" header="[[i18n('cycleCount')]]"
value="[[batteryHealth_.cycle_count]]"> value="[[batteryHealth_.cycle_count]]">
</data-point> </data-point>
</diagnostics-card> </diagnostics-card>
...@@ -8,13 +8,13 @@ ...@@ -8,13 +8,13 @@
user="[[cpuUsage_.percent_usage_user]]" user="[[cpuUsage_.percent_usage_user]]"
system="[[cpuUsage_.percent_usage_system]]"> system="[[cpuUsage_.percent_usage_system]]">
</realtime-cpu-chart> </realtime-cpu-chart>
<data-point slot="body" id="cpuUsageUser" <data-point slot="body" id="cpuUsageUser" header="[[i18n('cpuUsage')]]"
value="[[computeCurrentlyUsing_(cpuUsage_.percent_usage_system, value="[[computeCurrentlyUsing_(cpuUsage_.percent_usage_system,
cpuUsage_.percent_usage_user)]]"> cpuUsage_.percent_usage_user)]]">
</data-point> </data-point>
<!-- TODO(michaelcheco): Investigate whether or not temperature can be <!-- TODO(michaelcheco): Investigate whether or not temperature can be
localized. --> localized. -->
<data-point slot="body" id="cpuTemp" <data-point slot="body" id="cpuTemp" header="[[i18n('cpuTemp')]]"
value="[[cpuUsage_.cpu_temp_degrees_celcius]]"> value="[[cpuUsage_.cpu_temp_degrees_celcius]]">
</data-point> </data-point>
</diagnostics-card> </diagnostics-card>
...@@ -20,9 +20,8 @@ Polymer({ ...@@ -20,9 +20,8 @@ Polymer({
properties: { properties: {
header: { header: {
type: String, type: String,
// TODO(michaelcheco): Remove when localized strings are added.
value: 'Xxxx',
}, },
value: { value: {
type: String, type: String,
value: '', value: '',
......
...@@ -8,10 +8,11 @@ ...@@ -8,10 +8,11 @@
value="[[getTotalUsedMemory_(memoryUsage_)]]" value="[[getTotalUsedMemory_(memoryUsage_)]]"
max="[[memoryUsage_.total_memory_kib]]"> max="[[memoryUsage_.total_memory_kib]]">
</percent-bar-chart> </percent-bar-chart>
<data-point slot="body" id="memoryTotal" <data-point slot="body" id="memoryTotal" header="[[i18n('totalMemory')]]"
value="[[memoryUsage_.total_memory_kib]]"> value="[[memoryUsage_.total_memory_kib]]">
</data-point> </data-point>
<data-point slot="body" id="memoryAvailable" <data-point slot="body" id="memoryAvailable"
header="[[i18n('memoryAvailable')]]"
value="[[memoryUsage_.available_memory_kib]]"> value="[[memoryUsage_.available_memory_kib]]">
</data-point> </data-point>
</diagnostics-card> </diagnostics-card>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment