Commit 15e2397e authored by cylee's avatar cylee Committed by Commit bot

Remove flag --disable-genius-app since it's been public launched for several milestones

BUG=chromium:350245

Review URL: https://codereview.chromium.org/581583003

Cr-Commit-Position: refs/heads/master@{#295517}
parent 35df204b
...@@ -503,13 +503,11 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages( ...@@ -503,13 +503,11 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
#if defined(OS_CHROMEOS) && defined(GOOGLE_CHROME_BUILD) #if defined(OS_CHROMEOS) && defined(GOOGLE_CHROME_BUILD)
// Since this is a v2 app it has a background page. // Since this is a v2 app it has a background page.
if (!command_line->HasSwitch(chromeos::switches::kDisableGeniusApp)) { AddWithNameAndDescription(IDR_GENIUS_APP_MANIFEST,
AddWithNameAndDescription(IDR_GENIUS_APP_MANIFEST, base::FilePath(FILE_PATH_LITERAL(
base::FilePath(FILE_PATH_LITERAL( "/usr/share/chromeos-assets/genius_app")),
"/usr/share/chromeos-assets/genius_app")), IDS_GENIUS_APP_NAME,
IDS_GENIUS_APP_NAME, IDS_GENIUS_APP_DESCRIPTION);
IDS_GENIUS_APP_DESCRIPTION);
}
#endif #endif
if (!skip_session_components) { if (!skip_session_components) {
......
...@@ -36,7 +36,6 @@ ...@@ -36,7 +36,6 @@
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/genius_app/app_id.h" #include "chrome/browser/chromeos/genius_app/app_id.h"
#include "chromeos/chromeos_switches.h"
#include "extensions/browser/extension_registry.h" #include "extensions/browser/extension_registry.h"
#endif #endif
...@@ -76,16 +75,12 @@ void ShowHelpImpl(Browser* browser, ...@@ -76,16 +75,12 @@ void ShowHelpImpl(Browser* browser,
HelpSource source) { HelpSource source) {
content::RecordAction(UserMetricsAction("ShowHelpTab")); content::RecordAction(UserMetricsAction("ShowHelpTab"));
#if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD) #if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
const CommandLine* command_line = CommandLine::ForCurrentProcess(); const extensions::Extension* extension =
if (!command_line->HasSwitch(chromeos::switches::kDisableGeniusApp)) { extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
const extensions::Extension* extension = genius_app::kGeniusAppId,
extensions::ExtensionRegistry::Get(profile)->GetExtensionById( extensions::ExtensionRegistry::EVERYTHING);
genius_app::kGeniusAppId, OpenApplication(AppLaunchParams(profile, extension, 0, host_desktop_type));
extensions::ExtensionRegistry::EVERYTHING); #else
OpenApplication(AppLaunchParams(profile, extension, 0, host_desktop_type));
return;
}
#endif
GURL url; GURL url;
switch (source) { switch (source) {
case HELP_SOURCE_KEYBOARD: case HELP_SOURCE_KEYBOARD:
...@@ -107,6 +102,7 @@ void ShowHelpImpl(Browser* browser, ...@@ -107,6 +102,7 @@ void ShowHelpImpl(Browser* browser,
browser = displayer->browser(); browser = displayer->browser();
} }
ShowSingletonTab(browser, url); ShowSingletonTab(browser, url);
#endif
} }
} // namespace } // namespace
......
...@@ -199,12 +199,10 @@ class WrenchMenuModel::HelpMenuModel : public ui::SimpleMenuModel { ...@@ -199,12 +199,10 @@ class WrenchMenuModel::HelpMenuModel : public ui::SimpleMenuModel {
private: private:
void Build(Browser* browser) { void Build(Browser* browser) {
int help_string_id = IDS_HELP_PAGE;
#if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD) #if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
if (!CommandLine::ForCurrentProcess()->HasSwitch( int help_string_id = IDS_GET_HELP;
chromeos::switches::kDisableGeniusApp)) { #else
help_string_id = IDS_GET_HELP; int help_string_id = IDS_HELP_PAGE;
}
#endif #endif
AddItemWithStringId(IDC_HELP_PAGE_VIA_MENU, help_string_id); AddItemWithStringId(IDC_HELP_PAGE_VIA_MENU, help_string_id);
if (browser_defaults::kShowHelpMenuItemIcon) { if (browser_defaults::kShowHelpMenuItemIcon) {
......
...@@ -37,9 +37,6 @@ const char kDisableBootAnimation[] = "disable-boot-animation"; ...@@ -37,9 +37,6 @@ const char kDisableBootAnimation[] = "disable-boot-animation";
// Disables the ChromeOS demo. // Disables the ChromeOS demo.
const char kDisableDemoMode[] = "disable-demo-mode"; const char kDisableDemoMode[] = "disable-demo-mode";
// Disable Genius App and use the original Help App instead.
const char kDisableGeniusApp[] = "disable-genius-app";
// Disable HID-detection OOBE screen. // Disable HID-detection OOBE screen.
const char kDisableHIDDetectionOnOOBE[] = "disable-hid-detection-on-oobe"; const char kDisableHIDDetectionOnOOBE[] = "disable-hid-detection-on-oobe";
......
...@@ -30,7 +30,6 @@ CHROMEOS_EXPORT extern const char kDerelictIdleTimeout[]; ...@@ -30,7 +30,6 @@ CHROMEOS_EXPORT extern const char kDerelictIdleTimeout[];
CHROMEOS_EXPORT extern const char kDisableBootAnimation[]; CHROMEOS_EXPORT extern const char kDisableBootAnimation[];
CHROMEOS_EXPORT extern const char kDisableDemoMode[]; CHROMEOS_EXPORT extern const char kDisableDemoMode[];
CHROMEOS_EXPORT extern const char kDisableGaiaServices[]; CHROMEOS_EXPORT extern const char kDisableGaiaServices[];
CHROMEOS_EXPORT extern const char kDisableGeniusApp[];
CHROMEOS_EXPORT extern const char kDisableHIDDetectionOnOOBE[]; CHROMEOS_EXPORT extern const char kDisableHIDDetectionOnOOBE[];
CHROMEOS_EXPORT extern const char kDisableLoginAnimations[]; CHROMEOS_EXPORT extern const char kDisableLoginAnimations[];
CHROMEOS_EXPORT extern const char kDisableLoginScrollIntoView[]; CHROMEOS_EXPORT extern const char kDisableLoginScrollIntoView[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment