Commit 15ea8f58 authored by Regan Hsu's avatar Regan Hsu Committed by Chromium LUCI CQ

[CrOS PhoneHub] Add comment to remove TriggerRefresh() in the future.

Currently, calling syncer::SyncService::TriggerRefresh() in BrowserTabsModelProvider doesn't guarantee an immediate update.
It bypasses some of the potential sources of latency (e.g. for
delivering an invalidation), but not others (e.g. backend replication
delay). This method of refreshing browser tabs should be replaced when
there is a better means.

Fixed: 1158480
Change-Id: Id3043a3197cfc8dc88f18fb50c8a3e64ccc09a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618064Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841536}
parent 890c9170
...@@ -55,6 +55,12 @@ void BrowserTabsModelProviderImpl::OnHostStatusChanged( ...@@ -55,6 +55,12 @@ void BrowserTabsModelProviderImpl::OnHostStatusChanged(
} }
void BrowserTabsModelProviderImpl::TriggerRefresh() { void BrowserTabsModelProviderImpl::TriggerRefresh() {
// crbug/1158480: Currently (January 2021), updates to synced sessions
// sometimes take a long time to arrive. As a workaround,
// SyncService::TriggerRefresh() is used, which bypasses some of the potential
// sources of latency (e.g. for delivering an invalidation), but not others
// (e.g. backend replication delay). I.e SyncService::TriggerRefresh() will
// not guarantee an immediate update.
sync_service_->TriggerRefresh({syncer::SESSIONS}); sync_service_->TriggerRefresh({syncer::SESSIONS});
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment