Commit 15f03cd7 authored by Oriol Brufau's avatar Oriol Brufau Committed by Commit Bot

[css-pseudo] Cleanup list markers exclusions from anonymous boxes

Some functions check whether a LayoutObject is anonymous, and then they
exclude it if it's a list marker. However, since r745012, list markers
can never be anonymous, they are always generated by a ::marker pseudo-
element. Therefore, the condition is useless and can be removed.

BUG=457718

Change-Id: I5e2636f68fab483838e8a5227ccace34b6de22cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250102Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#779781}
parent 59b12e1f
...@@ -3101,8 +3101,7 @@ void LayoutBlockFlow::RemoveChild(LayoutObject* old_child) { ...@@ -3101,8 +3101,7 @@ void LayoutBlockFlow::RemoveChild(LayoutObject* old_child) {
// If we are an empty anonymous block in the continuation chain, // If we are an empty anonymous block in the continuation chain,
// we need to remove ourself and fix the continuation chain. // we need to remove ourself and fix the continuation chain.
if (!BeingDestroyed() && IsAnonymousBlockContinuation() && if (!BeingDestroyed() && IsAnonymousBlockContinuation()) {
!old_child->IsListMarker()) {
LayoutObject* containing_block_ignoring_anonymous = ContainingBlock(); LayoutObject* containing_block_ignoring_anonymous = ContainingBlock();
while (containing_block_ignoring_anonymous && while (containing_block_ignoring_anonymous &&
containing_block_ignoring_anonymous->IsAnonymous()) containing_block_ignoring_anonymous->IsAnonymous())
......
...@@ -960,8 +960,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver, ...@@ -960,8 +960,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
(StyleRef().Display() == EDisplay::kBlock || (StyleRef().Display() == EDisplay::kBlock ||
StyleRef().Display() == EDisplay::kWebkitBox) && StyleRef().Display() == EDisplay::kWebkitBox) &&
StyleRef().StyleType() == kPseudoIdNone && IsLayoutBlock() && StyleRef().StyleType() == kPseudoIdNone && IsLayoutBlock() &&
!IsListMarker() && !IsLayoutFlowThread() && !IsLayoutFlowThread() && !IsLayoutMultiColumnSet();
!IsLayoutMultiColumnSet();
} }
// If node has been split into continuations, it returns the first layout // If node has been split into continuations, it returns the first layout
// object generated for the node. // object generated for the node.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment