Commit 15f786ea authored by Robert Ogden's avatar Robert Ogden Committed by Commit Bot

Previews Omnibox UI: Add highlight to IPH Anchor view

This came up in review, but when the IPH bubble shows, it should
highlight the anchor view.

This CL does that with a simple call to ViewHighlighter

Bug: 902817
Change-Id: I003e3d1ea0304badcf42ef922f82caf0d6e548b1
Reviewed-on: https://chromium-review.googlesource.com/c/1323618Reviewed-by: default avatarDoug Arnett <dougarnett@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606215}
parent 03da52a4
......@@ -92,6 +92,7 @@ import org.chromium.chrome.browser.tabmodel.TabReparentingParams;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.vr.VrModuleProvider;
import org.chromium.chrome.browser.widget.PulseDrawable;
import org.chromium.chrome.browser.widget.ViewHighlighter;
import org.chromium.chrome.browser.widget.textbubble.TextBubble;
import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;
import org.chromium.components.embedder_support.view.ContentView;
......@@ -1626,6 +1627,7 @@ public class Tab
ThreadUtils.postOnUiThread(new Runnable() {
@Override
public void run() {
ViewHighlighter.turnOffHighlight(anchorView);
tracker.dismissed(FeatureConstants.PREVIEWS_OMNIBOX_UI_FEATURE);
}
});
......@@ -1635,6 +1637,7 @@ public class Tab
R.dimen.text_bubble_menu_anchor_y_inset);
rectProvider.setInsetPx(0, 0, 0, yInsetPx);
textBubble.show();
ViewHighlighter.turnOnHighlight(anchorView, true);
}
/**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment