Skip to content

GitLab

T
tangled
Commit 160badd0 authored by kevers@chromium.org's avatar kevers@chromium.org
Browse files
Options

Fix text alignment on settings/system page. 

Fixes the vertical alignment of titles on the settings/system page for Chrome OS. Fixed the positioning of slider labels for RTL languages.

TEST=Launch Chrome built for Chrome OS.  Switch to the settings/system page.  Inspect the vertical alignment of titles.  Relaunch in Arabic.  Check the positioning of the slider labels.


Review URL: http://codereview.chromium.org/7108040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88663 0039d316-1c4b-4281-b951-d872f2087c98
parent 80a84496
Hide whitespace changes
Inline Side-by-side
Showing with 74 additions and 73 deletions
chrome/browser/resources/options/chromeos/accounts_options_page.css
View file @ 160badd0
...@@ -73,7 +73,6 @@ ...@@ -73,7 +73,6 @@
width: 366px; width: 366px;
} }
#ownerOnlyWarning { #ownerOnlyWarning {
margin-top: 10px; margin-top: 10px;
margin-bottom: 10px; margin-bottom: 10px;
......
chrome/browser/resources/options/chromeos/system_options.html
View file @ 160badd0
...@@ -3,91 +3,74 @@ ...@@ -3,91 +3,74 @@
<div class="displaytable"> <div class="displaytable">
<section> <section>
<h3 i18n-content="datetime_title"></h3> <h3 i18n-content="datetime_title"></h3>
<table class="option-control-table"> <div class="option-control-table">
<tr> <span class="option-name" i18n-content="timezone"></span>
<td class="option-name" i18n-content="timezone"></td> <div id="timezone-value">
<td class="option-value">
<select id="timezone-select" class="control" <select id="timezone-select" class="control"
i18n-options="timezoneList" i18n-options="timezoneList"
dataType="string" dataType="string"
pref="cros.system.timezone"></select> pref="cros.system.timezone"></select>
</td> </div>
<tr> <div class="checkbox">
<td class="option-name" colspan="2"> <label>
<div class="checkbox"> <input id="use-24hour-clock"
<label> pref="settings.clock.use_24hour_clock"
<input id="use-24hour-clock" type="checkbox">
pref="settings.clock.use_24hour_clock" <span i18n-content="use_24hour_clock"></span>
type="checkbox"> </label>
<span i18n-content="use_24hour_clock"></span> </div>
</label> </div>
</div>
</td>
</tr>
</tr>
</table>
</section> </section>
<section> <section>
<h3 i18n-content="touchpad"></h3> <h3 i18n-content="touchpad"></h3>
<table class="option-control-table"> <div class="option-control-table">
<tr> <span class="option-name" i18n-content="sensitivity"></span>
<td class="option-name" i18n-content="sensitivity"></td> <div id="touchpad-value">
<td class="option-value"> <div id="slider-control">
<input id="sensitivity-range" type="range" min="1" max="5" <input id="sensitivity-range" type="range" min="1" max="5"
pref="settings.touchpad.sensitivity2" class="touch-slider"> pref="settings.touchpad.sensitivity2" class="touch-slider">
</td> <div>
</tr> <span i18n-content="sensitivity_less"></span>
<tr> <span i18n-content="sensitivity_more"
<td></td> class="touchpad-sensitivity-more"></span>
<td>
<span i18n-content="sensitivity_less"></span>
<span i18n-content="sensitivity_more"
class="touchpad-sensitivity-more"></span>
</td>
</tr>
<tr>
<td class="option-name" colspan="2">
<div class="checkbox">
<label>
<input id="tap-to-click-check"
pref="settings.touchpad.enable_tap_to_click"
type="checkbox">
<span i18n-content="enable_tap_to_click"></span>
</label>
</div> </div>
</td> </div>
</tr> </div>
</table> <div class="checkbox">
<label>
<input id="tap-to-click-check"
pref="settings.touchpad.enable_tap_to_click"
type="checkbox">
<span i18n-content="enable_tap_to_click"></span>
</label>
</div>
</div>
</section> </section>
<section> <section>
<h3 i18n-content="language"></h3> <h3 i18n-content="language"></h3>
<table class="option-control-table"> <div class="option-control-table">
<tr> <div class="option-name">
<td class="option-name"> <button id="language-button" i18n-content="language_customize">
<button id="language-button" i18n-content="language_customize"> </button>
</button> </div>
</td> <div class="option-name">
<td class="option-name"> <button id="modifier-keys-button"
<button id="modifier-keys-button" i18n-content="modifier_keys_customize"></button>
i18n-content="modifier_keys_customize"></button> </div>
</td> </div>
</tr>
</table>
</section> </section>
<section> <section>
<h3 i18n-content="accessibility_title"></h3> <h3 i18n-content="accessibility_title"></h3>
<table class="option-control-table"> <div class="option-control-table">
<tr> <div class="option-name">
<td class="option-name"> <div class="checkbox">
<div class="checkbox"> <label>
<label> <input id="accesibility-check" type="checkbox">
<input id="accesibility-check" type="checkbox"> <span i18n-content="accessibility"></span>
<span i18n-content="accessibility"></span> </label>
</label> </div>
</div> </div>
</td> </div>
</tr>
</table>
</section> </section>
</div> </div>
</div> </div>
chrome/browser/resources/options/chromeos/system_options_page.css
View file @ 160badd0
.touchpad-sensitivity-more { .touchpad-sensitivity-more {
float: right; float: right;
} }
html[dir=rtl] .touchpad-sensitivity-more {
float: left;
}
.option-name {
display: inline;
}
#timezone-value {
display: inline-block;
vertical-align: baseline;
}
#touchpad-value,
#slider-control {
display: inline-block;
vertical-align: top;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment