Commit 160cebfe authored by Eric Stevenson's avatar Eric Stevenson Committed by Commit Bot

JNI refactor: @NativeMethods conversion (//printing).

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: Id6b2e31c1176244a50e718d0fd283ca2fe9403e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809400
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: default avatarShimi Zhang <ctzsm@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697332}
parent 6d1f0123
......@@ -382,6 +382,7 @@ if (is_android) {
android_library("printing_java") {
deps = [
"//base:base_java",
"//base:jni_java",
"//ui/android:ui_java",
]
java_files = [
......@@ -393,5 +394,6 @@ if (is_android) {
"android/java/src/org/chromium/printing/PrintingController.java",
"android/java/src/org/chromium/printing/PrintingControllerImpl.java",
]
annotation_processor_deps = [ "//base/android/jni_generator:jni_processor" ]
}
}
......@@ -10,6 +10,7 @@ import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.ui.base.WindowAndroid;
/**
......@@ -106,8 +107,8 @@ public class PrintingContext {
ThreadUtils.assertOnUiThread();
// If the printing dialog has already finished, tell Chromium that operation is cancelled.
if (mController.hasPrintingFinished()) {
// NOTE: We don't call nativeAskUserForSettingsReply (hence Chromium callback in
// AskUserForSettings callback) twice.
// NOTE: We don't call PrintingContextJni.get().askUserForSettingsReply (hence Chromium
// callback in AskUserForSettings callback) twice.
askUserForSettingsReply(false);
} else {
mController.setPrintingContext(this);
......@@ -117,16 +118,19 @@ public class PrintingContext {
private void askUserForSettingsReply(boolean success) {
assert mNativeObject != 0;
nativeAskUserForSettingsReply(mNativeObject, success);
PrintingContextJni.get().askUserForSettingsReply(
mNativeObject, PrintingContext.this, success);
}
private void showSystemDialogDone() {
assert mNativeObject != 0;
nativeShowSystemDialogDone(mNativeObject);
PrintingContextJni.get().showSystemDialogDone(mNativeObject, PrintingContext.this);
}
private native void nativeAskUserForSettingsReply(
long nativePrintingContextAndroid, boolean success);
private native void nativeShowSystemDialogDone(long nativePrintingContextAndroid);
@NativeMethods
interface Natives {
void askUserForSettingsReply(
long nativePrintingContextAndroid, PrintingContext caller, boolean success);
void showSystemDialogDone(long nativePrintingContextAndroid, PrintingContext caller);
}
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment