Commit 162e126f authored by bjornv's avatar bjornv Committed by Commit bot

content/renderer/media/: Change when to populate WebRTC.AecDelayBasedQuality

Previously the WebRTC.AecDelayBasedQuality histogram was populated even when the call to fetch the metrics from WebRTC failed. This CL makes sure we only populate upon success.

BUG=450193

Review URL: https://codereview.chromium.org/999203003

Cr-Commit-Position: refs/heads/master@{#322556}
parent 9fe1bd70
......@@ -249,12 +249,13 @@ void EchoInformation::UpdateAecDelayStats(
&dummy_median, &dummy_std, &fraction_poor_delays) ==
webrtc::AudioProcessing::kNoError) {
num_chunks_ = 0;
// Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
// histogram. See DelayBasedEchoQuality for information on histogram
// buckets.
UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
EchoDelayFrequencyToQuality(fraction_poor_delays),
DELAY_BASED_ECHO_QUALITY_MAX);
}
// Map |fraction_poor_delays| to an Echo Cancellation quality and log in UMA
// histogram. See DelayBasedEchoQuality for information on histogram buckets.
UMA_HISTOGRAM_ENUMERATION("WebRTC.AecDelayBasedQuality",
EchoDelayFrequencyToQuality(fraction_poor_delays),
DELAY_BASED_ECHO_QUALITY_MAX);
}
void EnableEchoCancellation(AudioProcessing* audio_processing) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment