Commit 16301413 authored by Scott Violet's avatar Scott Violet Committed by Commit Bot

views: update deps

This removes services/ws/public from views DEPs as it's not needed.
This also adds an explicit DEP from views onto ui/latency, and an explicit
include from HWNDMessageHandler (which is using ui/latency). ui/events has a
public_dep on ui/latency, but ui/latency is a source_set. Views was likely
getting ui/latency via services/ws/public/public some how. With the services/ws
dep removed, link errors results. As ui/latency is a source_set and views
is directly dependencing upon ui/latency, views should have an explicit
dep on ui/latency.

BUG=964460
TEST=none

Change-Id: I5bc159b7cfe8dd15089ff88200cad8692a5b1572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635772Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664483}
parent d1fbdd86
...@@ -502,12 +502,12 @@ jumbo_component("views") { ...@@ -502,12 +502,12 @@ jumbo_component("views") {
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//cc/paint", "//cc/paint",
"//mojo/public/cpp/bindings", "//mojo/public/cpp/bindings",
"//services/ws/public/mojom",
"//skia", "//skia",
"//third_party/icu", "//third_party/icu",
"//ui/accessibility", "//ui/accessibility",
"//ui/base/clipboard", "//ui/base/clipboard",
"//ui/display", "//ui/display",
"//ui/latency",
"//ui/native_theme", "//ui/native_theme",
"//ui/native_theme:native_theme_browser", "//ui/native_theme:native_theme_browser",
"//ui/resources", "//ui/resources",
...@@ -677,7 +677,6 @@ jumbo_component("views") { ...@@ -677,7 +677,6 @@ jumbo_component("views") {
"widget/window_reorderer.cc", "widget/window_reorderer.cc",
] ]
deps += [ deps += [
"//services/ws/public/mojom",
"//ui/aura", "//ui/aura",
"//ui/events", "//ui/events",
"//ui/platform_window", "//ui/platform_window",
...@@ -1084,7 +1083,6 @@ test("views_unittests") { ...@@ -1084,7 +1083,6 @@ test("views_unittests") {
"//components/vector_icons", "//components/vector_icons",
"//components/viz/common", "//components/viz/common",
"//mojo/core/embedder", "//mojo/core/embedder",
"//services/ws/public/mojom",
"//skia", "//skia",
"//testing/gtest", "//testing/gtest",
"//third_party/icu", "//third_party/icu",
......
...@@ -4,7 +4,6 @@ include_rules = [ ...@@ -4,7 +4,6 @@ include_rules = [
"+components/remote_cocoa", "+components/remote_cocoa",
"+components/vector_icons", "+components/vector_icons",
"+mojo/public/cpp/bindings", "+mojo/public/cpp/bindings",
"+services/ws/public/mojom",
"+skia/ext", "+skia/ext",
"+third_party/iaccessible2", "+third_party/iaccessible2",
"+third_party/skia", "+third_party/skia",
......
...@@ -15,6 +15,7 @@ include_rules = [ ...@@ -15,6 +15,7 @@ include_rules = [
"+base", "+base",
"+ui/base", "+ui/base",
"+ui/gfx", "+ui/gfx",
"+ui/latency",
"+ui/views/accessibility/native_view_accessibility_win.h", "+ui/views/accessibility/native_view_accessibility_win.h",
"+ui/views/ime/input_method_delegate.h", "+ui/views/ime/input_method_delegate.h",
"+ui/views/views_delegate.h", "+ui/views/views_delegate.h",
......
...@@ -55,6 +55,7 @@ ...@@ -55,6 +55,7 @@
#include "ui/gfx/path_win.h" #include "ui/gfx/path_win.h"
#include "ui/gfx/win/hwnd_util.h" #include "ui/gfx/win/hwnd_util.h"
#include "ui/gfx/win/rendering_window_manager.h" #include "ui/gfx/win/rendering_window_manager.h"
#include "ui/latency/latency_info.h"
#include "ui/native_theme/native_theme_win.h" #include "ui/native_theme/native_theme_win.h"
#include "ui/views/views_delegate.h" #include "ui/views/views_delegate.h"
#include "ui/views/widget/widget_hwnd_utils.h" #include "ui/views/widget/widget_hwnd_utils.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment