Commit 16498df8 authored by Oksana Zhuravlova's avatar Oksana Zhuravlova Committed by Commit Bot

[mojo] Convert PushMessagingClient to use BrowserInterfaceBroker

Bug: 995422
Change-Id: I384e85321bdc8987e0e39a633833bb242354dfc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811990Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Reviewed-by: default avatarRichard Knoll <knollr@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699853}
parent 7c770f70
...@@ -82,6 +82,9 @@ void PopulateFrameBinders(RenderFrameHostImpl* host, ...@@ -82,6 +82,9 @@ void PopulateFrameBinders(RenderFrameHostImpl* host,
map->Add<blink::mojom::WebBluetoothService>(base::BindRepeating( map->Add<blink::mojom::WebBluetoothService>(base::BindRepeating(
&RenderFrameHostImpl::CreateWebBluetoothService, base::Unretained(host))); &RenderFrameHostImpl::CreateWebBluetoothService, base::Unretained(host)));
map->Add<blink::mojom::PushMessaging>(base::BindRepeating(
&RenderFrameHostImpl::GetPushMessaging, base::Unretained(host)));
} }
void PopulateBinderMapWithContext( void PopulateBinderMapWithContext(
......
...@@ -1083,6 +1083,9 @@ class CONTENT_EXPORT RenderFrameHostImpl ...@@ -1083,6 +1083,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
void CreateWebBluetoothService( void CreateWebBluetoothService(
mojo::PendingReceiver<blink::mojom::WebBluetoothService> receiver); mojo::PendingReceiver<blink::mojom::WebBluetoothService> receiver);
void GetPushMessaging(
mojo::PendingReceiver<blink::mojom::PushMessaging> receiver);
// https://mikewest.github.io/corpp/#initialize-embedder-policy-for-global // https://mikewest.github.io/corpp/#initialize-embedder-policy-for-global
network::mojom::CrossOriginEmbedderPolicy cross_origin_embedder_policy() network::mojom::CrossOriginEmbedderPolicy cross_origin_embedder_policy()
const { const {
...@@ -1597,8 +1600,6 @@ class CONTENT_EXPORT RenderFrameHostImpl ...@@ -1597,8 +1600,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
mojo::PendingReceiver<blink::mojom::CredentialManager> receiver) override; mojo::PendingReceiver<blink::mojom::CredentialManager> receiver) override;
void GetAuthenticator( void GetAuthenticator(
mojo::PendingReceiver<blink::mojom::Authenticator> receiver) override; mojo::PendingReceiver<blink::mojom::Authenticator> receiver) override;
void GetPushMessaging(
mojo::PendingReceiver<blink::mojom::PushMessaging> receiver) override;
void GetVirtualAuthenticatorManager( void GetVirtualAuthenticatorManager(
mojo::PendingReceiver<blink::test::mojom::VirtualAuthenticatorManager> mojo::PendingReceiver<blink::test::mojom::VirtualAuthenticatorManager>
receiver) override; receiver) override;
......
...@@ -788,8 +788,6 @@ class TestSimpleDocumentInterfaceBrokerImpl ...@@ -788,8 +788,6 @@ class TestSimpleDocumentInterfaceBrokerImpl
mojo::PendingReceiver<blink::mojom::CredentialManager>) override {} mojo::PendingReceiver<blink::mojom::CredentialManager>) override {}
void GetAuthenticator( void GetAuthenticator(
mojo::PendingReceiver<blink::mojom::Authenticator> receiver) override {} mojo::PendingReceiver<blink::mojom::Authenticator> receiver) override {}
void GetPushMessaging(
mojo::PendingReceiver<blink::mojom::PushMessaging> receiver) override {}
void GetVirtualAuthenticatorManager( void GetVirtualAuthenticatorManager(
mojo::PendingReceiver<blink::test::mojom::VirtualAuthenticatorManager> mojo::PendingReceiver<blink::test::mojom::VirtualAuthenticatorManager>
receiver) override {} receiver) override {}
......
...@@ -6,7 +6,6 @@ module blink.mojom; ...@@ -6,7 +6,6 @@ module blink.mojom;
import "third_party/blink/public/mojom/credentialmanager/credential_manager.mojom"; import "third_party/blink/public/mojom/credentialmanager/credential_manager.mojom";
import "third_party/blink/public/mojom/frame/frame_host_test_interface.mojom"; import "third_party/blink/public/mojom/frame/frame_host_test_interface.mojom";
import "third_party/blink/public/mojom/push_messaging/push_messaging.mojom";
import "third_party/blink/public/mojom/webauthn/authenticator.mojom"; import "third_party/blink/public/mojom/webauthn/authenticator.mojom";
import "third_party/blink/public/mojom/webauthn/virtual_authenticator.mojom"; import "third_party/blink/public/mojom/webauthn/virtual_authenticator.mojom";
...@@ -30,11 +29,6 @@ interface DocumentInterfaceBroker { ...@@ -30,11 +29,6 @@ interface DocumentInterfaceBroker {
GetFrameHostTestInterface( GetFrameHostTestInterface(
pending_receiver<blink.mojom.FrameHostTestInterface> receiver); pending_receiver<blink.mojom.FrameHostTestInterface> receiver);
// Binds the blink.mojom.PushMessaging pending receiver to its remote
// implementation in the browser process, to allow subscribing, unsubscribing
// and retrieving subscriptions related to push notifications (see Push API).
GetPushMessaging(pending_receiver<blink.mojom.PushMessaging> receiver);
// Binds the blink.test.mojom.VirtualAuthenticatorManager pending receiver to // Binds the blink.test.mojom.VirtualAuthenticatorManager pending receiver to
// its remote implementation in the browser process, to manage a virtual // its remote implementation in the browser process, to manage a virtual
// environment that allows talking virtual authenticators via the WebAuth API. // environment that allows talking virtual authenticators via the WebAuth API.
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
#include <string> #include <string>
#include <utility> #include <utility>
#include "third_party/blink/public/mojom/frame/document_interface_broker.mojom-blink.h" #include "third_party/blink/public/common/browser_interface_broker_proxy.h"
#include "third_party/blink/public/mojom/push_messaging/push_messaging_status.mojom-blink.h" #include "third_party/blink/public/mojom/push_messaging/push_messaging_status.mojom-blink.h"
#include "third_party/blink/public/platform/platform.h" #include "third_party/blink/public/platform/platform.h"
#include "third_party/blink/public/web/web_local_frame.h" #include "third_party/blink/public/web/web_local_frame.h"
...@@ -43,7 +43,7 @@ PushMessagingClient* PushMessagingClient::From(LocalFrame* frame) { ...@@ -43,7 +43,7 @@ PushMessagingClient* PushMessagingClient::From(LocalFrame* frame) {
mojom::blink::PushMessaging* PushMessagingClient::GetPushMessagingRemote() { mojom::blink::PushMessaging* PushMessagingClient::GetPushMessagingRemote() {
if (!push_messaging_manager_) { if (!push_messaging_manager_) {
GetSupplementable()->GetDocumentInterfaceBroker().GetPushMessaging( GetSupplementable()->GetBrowserInterfaceBroker().GetInterface(
push_messaging_manager_.BindNewPipeAndPassReceiver( push_messaging_manager_.BindNewPipeAndPassReceiver(
GetSupplementable()->GetTaskRunner(TaskType::kMiscPlatformAPI))); GetSupplementable()->GetTaskRunner(TaskType::kMiscPlatformAPI)));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment