Commit 16740b37 authored by ckitagawa's avatar ckitagawa Committed by Commit Bot

[Paint Preview] Correct unparsable subframe field in proto

Protos that populate the subframe field aren't parsable once serialized
as the is_main_frame field isn't populated. This wasn't caught in any
tests and iframes aren't captured yet. I caught this when working on
some Cluster Telemetry metrics collection.

Bug: 1024640
Change-Id: I4632e07b165da3a47534081e6fa024573c5046ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914512Reviewed-by: default avatarMehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715278}
parent c72dc58f
......@@ -276,6 +276,7 @@ mojom::PaintPreviewStatus PaintPreviewClient::RecordFrame(
frame_proto->set_is_main_frame(true);
} else {
frame_proto = proto_ptr->add_subframes();
frame_proto->set_is_main_frame(false);
}
// Safe since always <#>.skp.
frame_proto->set_file_path(filename.AsUTF8Unsafe());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment