Commit 168835a0 authored by Asami Doi's avatar Asami Doi Committed by Commit Bot

Expose warn-only and enforce mode to chrome://flags

The feature CheckOfflineCapability feature has 3 states: disabled,
enabled with warn-only, and enabled with enforce.
This CL exposes all states of the feature to chrome://flags.

Bug: 965802
Change-Id: I657ffd8032016dead0115a59fcf6f2ca14a8d301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517278
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825242}
parent 2a415a20
......@@ -2377,6 +2377,18 @@ const FeatureEntry::FeatureVariation kSCTAuditingVariations[] = {
};
#endif // !defined(OS_ANDROID)
const FeatureEntry::FeatureParam kCheckOfflineCapabilityWarnOnly[] = {
{"check_mode", "warn_only"}};
const FeatureEntry::FeatureParam kCheckOfflineCapabilityEnforce[] = {
{"check_mode", "enforce"}};
const FeatureEntry::FeatureVariation kCheckOfflineCapabilityVariations[] = {
{"Warn-only", kCheckOfflineCapabilityWarnOnly,
base::size(kCheckOfflineCapabilityWarnOnly), nullptr},
{"Enforce", kCheckOfflineCapabilityEnforce,
base::size(kCheckOfflineCapabilityEnforce), nullptr},
};
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
......@@ -6658,7 +6670,9 @@ const FeatureEntry kFeatureEntries[] = {
{"check-offline-capability", flag_descriptions::kCheckOfflineCapabilityName,
flag_descriptions::kCheckOfflineCapabilityDescription, kOsAll,
FEATURE_VALUE_TYPE(blink::features::kCheckOfflineCapability)},
FEATURE_WITH_PARAMS_VALUE_TYPE(blink::features::kCheckOfflineCapability,
kCheckOfflineCapabilityVariations,
"CheckOfflineCapability")},
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment