Settings: Added new and changed incorrectly labelled histogram enums
The enum for the WebUI.Settings.PathVisited histogram recording the visit count for each settings route had two major issues: (1) Almost all of the site settings routes were labelled incorrectly (2) It didn't include several recently added routes, in particular those added as part of the browser/OS settings split (bug 950007). To deal with (1), I replaced all the incorrectly labelled site settings routes with the correct labelling. Generally this meant appending the string '/content' to the beginning of the label because the old label ignored Route.createChild() method's handling of paths that do not start with a slash [1] (the labels just added a slash at the beginning). I dealt with (2) by searching as described in the bug [2] for a comprehensive audit of relevant routes. The search turned up three routes that I believe came from changes that have been migrated away: (1) /help/management (2) /manageAccessibility/tts/googleTtsEngine (3) /parentalControls Because there is little cost to adding a couple unused values, I added them in Patchset 3 in case they are relevant for some edge case. If we need. to remove them again, I can revert it to the state of the CL in Patchset 2. NOTE: The hashes came from following the instructions in [4], following the approach of [5]. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route.js?rcl=9e4613082bd9a9972a6f5d21cb10f729fe1210bb&l=169 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=952472#c9 [3] https://uma.googleplex.com/p/chrome/histograms/?sid=7c5a1f5262a2ec196167d4546f6448af [4] https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97 [5] https://chromium-review.googlesource.com/c/chromium/src/+/1089716/ Bug: 952472, 950007 Change-Id: Iea237f3f7285e520a3ed96f12abeed24911d653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716215Reviewed-by:May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#680534}
Showing
Please register or sign in to comment