Commit 16bfdcc0 authored by Jordy Greenblatt's avatar Jordy Greenblatt Committed by Commit Bot

Settings: Added new and changed incorrectly labelled histogram enums

The enum for the WebUI.Settings.PathVisited histogram recording the
visit count for each settings route had two major issues:
(1) Almost all of the site settings routes were labelled incorrectly
(2) It didn't include several recently added routes, in particular
    those added as part of the browser/OS settings split (bug 950007).

To deal with (1), I replaced all the incorrectly labelled site settings
routes with the correct labelling. Generally this meant appending the
string '/content' to the beginning of the label because the old label
ignored Route.createChild() method's handling of paths that do not
start with a slash [1] (the labels just added a slash at the beginning).

I dealt with (2) by searching as described in the bug [2] for a
comprehensive audit of relevant routes. The search turned up three
routes that I believe came from changes that have been migrated away:
(1) /help/management
(2) /manageAccessibility/tts/googleTtsEngine
(3) /parentalControls
Because there is little cost to adding a couple unused values, I added
them in Patchset 3 in case they are relevant for some edge case. If we
need. to remove them again, I can revert it to the state of the CL in
Patchset 2.

NOTE: The hashes came from following the instructions in [4], following
the approach of [5].

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route.js?rcl=9e4613082bd9a9972a6f5d21cb10f729fe1210bb&l=169
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=952472#c9
[3] https://uma.googleplex.com/p/chrome/histograms/?sid=7c5a1f5262a2ec196167d4546f6448af
[4] https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97
[5] https://chromium-review.googlesource.com/c/chromium/src/+/1089716/

Bug: 952472, 950007
Change-Id: Iea237f3f7285e520a3ed96f12abeed24911d653b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716215Reviewed-by: default avatarMay Lippert <maybelle@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680534}
parent d91f455e
...@@ -61823,87 +61823,123 @@ Full version information for the fingerprint enum values: ...@@ -61823,87 +61823,123 @@ Full version information for the fingerprint enum values:
<enum name="WebUISettingsPathHashes"> <enum name="WebUISettingsPathHashes">
<int value="-2088016711" label="/startupPages"/> <int value="-2088016711" label="/startupPages"/>
<int value="-2082028555" label="/androidApps/details"/> <int value="-2082028555" label="/androidApps/details"/>
<int value="-2081867874" label="/usbDevices"/>
<int value="-2019732586" label="/printing"/> <int value="-2019732586" label="/printing"/>
<int value="-1950073287" label="/crostini/details"/>
<int value="-1930329480" label="/signOut"/> <int value="-1930329480" label="/signOut"/>
<int value="-1924511305" label="/help"/> <int value="-1924511305" label="/help"/>
<int value="-1915654604" label="/sound"/>
<int value="-1836863301" label="/ads"/>
<int value="-1820397898" label="/manageAccessibility"/> <int value="-1820397898" label="/manageAccessibility"/>
<int value="-1737559358" label="/flash"/> <int value="-1795544471" label="/languages/inputMethods"/>
<int value="-1791818691" label="/content/camera"/>
<int value="-1732727903" label="/kerberosAccounts"/>
<int value="-1688600161" label="/manageProfile"/> <int value="-1688600161" label="/manageProfile"/>
<int value="-1675675685" label="/content/clipboard"/>
<int value="-1610814282" label="/content/popups"/>
<int value="-1575150353" label="/content/cookies"/>
<int value="-1569772500" label="/manageAccessibility/tts"/> <int value="-1569772500" label="/manageAccessibility/tts"/>
<int value="-1351149930" label="/backgroundSync"/> <int value="-1555301506" label="/content/notifications"/>
<int value="-1484929503" label="/manageAccessibility/switchAccess"/>
<int value="-1312744606" label="/knownNetworks"/> <int value="-1312744606" label="/knownNetworks"/>
<int value="-1299234352" label="/pluginVm/details"/>
<int value="-1297176639" label="/fonts"/> <int value="-1297176639" label="/fonts"/>
<int value="-1283080115" label="/content/backgroundSync"/>
<int value="-1279337432" label="/power"/> <int value="-1279337432" label="/power"/>
<int value="-1227595649" label="/all"/> <int value="-1227595649" label="/all"/>
<int value="-1204780990" label="/dateTime/timeZone"/>
<int value="-1167413307" label="/inputMethods"/> <int value="-1167413307" label="/inputMethods"/>
<int value="-1165810228" label="/searchEngines"/> <int value="-1165810228" label="/searchEngines"/>
<int value="-1119639824" label="/display"/> <int value="-1119639824" label="/display"/>
<int value="-1068416040" label="/multidevice/features/smartLock"/>
<int value="-1058065329" label="/languages"/> <int value="-1058065329" label="/languages"/>
<int value="-1048015830" label="/"/> <int value="-1048015830" label="/"/>
<int value="-1024208058" label="/midiDevices"/> <int value="-1028177121" label="/content/serialPorts"/>
<int value="-1021686484" label="/javascript"/> <int value="-1007016915" label="/help/management"/>
<int value="-1006445425" label="/importData"/> <int value="-1006445425" label="/importData"/>
<int value="-988053194" label="/lockScreen"/> <int value="-988053194" label="/lockScreen"/>
<int value="-972517930" label="/googleAssistant"/> <int value="-972517930" label="/googleAssistant"/>
<int value="-940942794" label="/content/pdfDocuments"/>
<int value="-916174295" label="/internet"/> <int value="-916174295" label="/internet"/>
<int value="-907780721" label="/certificates"/> <int value="-907780721" label="/certificates"/>
<int value="-843556233" label="/location"/> <int value="-898481268" label="/multidevice/features"/>
<int value="-732448620" label="/pdfDocuments"/> <int value="-842548379" label="/apps"/>
<int value="-809146474" label="/content/location"/>
<int value="-794215283" label="/content/images"/>
<int value="-710357049" label="/bluetooth"/> <int value="-710357049" label="/bluetooth"/>
<int value="-686834549" label="/downloads"/> <int value="-686834549" label="/downloads"/>
<int value="-536183569" label="/protectedContent"/> <int value="-655433489" label="/payments"/>
<int value="-590688273" label="/content/sensors"/>
<int value="-570956986" label="/personalization"/>
<int value="-512116630" label="/search"/> <int value="-512116630" label="/search"/>
<int value="-482801316" label="/appearance"/> <int value="-482801316" label="/appearance"/>
<int value="-469021167" label="/resetProfileSettings"/> <int value="-469021167" label="/resetProfileSettings"/>
<int value="-442978022" label="/networks"/> <int value="-442978022" label="/networks"/>
<int value="-413956322" label="/content/zoomLevels"/>
<int value="-378866134" label="/networkDetail"/> <int value="-378866134" label="/networkDetail"/>
<int value="-372127353" label="/content/paymentHandler"/>
<int value="-327540120" label="/content/javascript"/>
<int value="-319293467" label="/multidevice"/> <int value="-319293467" label="/multidevice"/>
<int value="-300300075" label="/system"/> <int value="-300300075" label="/system"/>
<int value="-295702530" label="/smbShares"/>
<int value="-237154443" label="/manageAccessibility/tts/googleTtsEngine"/>
<int value="-230959653" label="/syncSetup"/> <int value="-230959653" label="/syncSetup"/>
<int value="-210069062" label="/content"/> <int value="-210069062" label="/content"/>
<int value="-189314307" label="/crostini/exportImport"/>
<int value="-152132510" label="/captions"/>
<int value="-146134264" label="/content/protectedContent"/>
<int value="-59332819" label="/accountManager"/>
<int value="-44267040" label="/bluetoothDevices"/> <int value="-44267040" label="/bluetoothDevices"/>
<int value="-14666765" label="/accounts"/> <int value="-14666765" label="/accounts"/>
<int value="16194264" label="/popups"/> <int value="8030578" label="/crostini/sharedUsbDevices"/>
<int value="48697687" label="/zoomLevels"/> <int value="8530592" label="/syncSetup/advanced"/>
<int value="16287984" label="/languages/details"/>
<int value="60238454" label="/content/ads"/>
<int value="223791833" label="/help/about"/> <int value="223791833" label="/help/about"/>
<int value="273561147" label="/autofill"/> <int value="273561147" label="/autofill"/>
<int value="297583680" label="/device"/> <int value="297583680" label="/device"/>
<int value="306239043" label="/camera"/>
<int value="334469894" label="/people"/> <int value="334469894" label="/people"/>
<int value="338873252" label="/passwords"/> <int value="338873252" label="/passwords"/>
<int value="350639838" label="/cookies"/>
<int value="408074355" label="/onStartup"/> <int value="408074355" label="/onStartup"/>
<int value="511430105" label="/automaticDownloads"/> <int value="463749620" label="/content/flash"/>
<int value="537677705" label="/cookies/detail"/> <int value="537677705" label="/cookies/detail"/>
<int value="547337090" label="/content/automaticDownloads"/>
<int value="614423407" label="/incompatibleApplications"/>
<int value="618530678" label="/advanced"/> <int value="618530678" label="/advanced"/>
<int value="682420978" label="/content/bluetoothScanning"/>
<int value="683177973" label="/cupsPrinters"/> <int value="683177973" label="/cupsPrinters"/>
<int value="754547746" label="/help/details"/> <int value="754547746" label="/help/details"/>
<int value="856943564" label="/content/siteDetails"/> <int value="856943564" label="/content/siteDetails"/>
<int value="868952532" label="/pointer-overlay"/> <int value="868952532" label="/pointer-overlay"/>
<int value="872535792" label="/parentalControls"/>
<int value="900733129" label="/content/microphone"/>
<int value="912274271" label="/siteData"/> <int value="912274271" label="/siteData"/>
<int value="943458628" label="/triggeredResetProfileSettings"/> <int value="943458628" label="/triggeredResetProfileSettings"/>
<int value="1001064152" label="/pluginVm"/>
<int value="1051104480" label="/cleanup"/>
<int value="1114615837" label="/accessibility"/> <int value="1114615837" label="/accessibility"/>
<int value="1147116633" label="/networkConfig"/> <int value="1147116633" label="/networkConfig"/>
<int value="1220946500" label="/notifications"/> <int value="1161126439" label="/content/midiDevices"/>
<int value="1225485397" label="/content/unsandboxedPlugins"/>
<int value="1258785570" label="/crostini/sharedPaths"/>
<int value="1289631391" label="/pluginVm/sharedPaths"/>
<int value="1300569861" label="/keyboard-overlay"/> <int value="1300569861" label="/keyboard-overlay"/>
<int value="1364454971" label="/androidApps"/> <int value="1364454971" label="/androidApps"/>
<int value="1383875055" label="/microphone"/>
<int value="1384165448" label="/stylus"/> <int value="1384165448" label="/stylus"/>
<int value="1462185522" label="/dateTime"/> <int value="1462185522" label="/dateTime"/>
<int value="1497571989" label="/images"/> <int value="1463148011" label="/securityKeys"/>
<int value="1513138656" label="/passwordsAndForms"/> <int value="1513138656" label="/passwordsAndForms"/>
<int value="1602314362" label="/storage"/> <int value="1602314362" label="/storage"/>
<int value="1641570017" label="/defaultBrowser"/> <int value="1641570017" label="/defaultBrowser"/>
<int value="1643599659" label="/content/usbDevices"/>
<int value="1661964813" label="/reset"/> <int value="1661964813" label="/reset"/>
<int value="1742260422" label="/cloudPrinters"/> <int value="1742260422" label="/cloudPrinters"/>
<int value="1798082697" label="/handlers"/> <int value="1798082697" label="/handlers"/>
<int value="1799541633" label="/addresses"/>
<int value="1810385625" label="/crostini"/>
<int value="1853516270" label="/lockScreen/fingerprint"/> <int value="1853516270" label="/lockScreen/fingerprint"/>
<int value="1935584577" label="/clearBrowserData"/> <int value="1935584577" label="/clearBrowserData"/>
<int value="1956464558" label="/changePicture"/> <int value="1956464558" label="/changePicture"/>
<int value="2083843665" label="/unsandboxedPlugins"/> <int value="2014923527" label="/storage/externalStoragePreferences"/>
<int value="2030415176" label="/files"/>
<int value="2037005918" label="/content/sound"/>
<int value="2127311241" label="/editDictionary"/> <int value="2127311241" label="/editDictionary"/>
<int value="2136150421" label="/content/all"/> <int value="2136150421" label="/content/all"/>
<int value="2136345292" label="/privacy"/> <int value="2136345292" label="/privacy"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment