Commit 16c7ca2d authored by Lily Chen's avatar Lily Chen Committed by Commit Bot

Fix slight inaccuracy in SameSite=None insecure cookie blocked reason

This fixes a slight inaccuracy in the tooltip string describing why
a cookie was blocked for being SameSite=None but not Secure.

Bug: 856777
Change-Id: I529eaa67380045fa86fd421664c2824638b851c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832522Reviewed-by: default avatarJoey Arhar <jarhar@chromium.org>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702044}
parent 25632066
...@@ -1485,7 +1485,7 @@ SDK.NetworkRequest.cookieBlockedReasonToUiString = function(blockedReason) { ...@@ -1485,7 +1485,7 @@ SDK.NetworkRequest.cookieBlockedReasonToUiString = function(blockedReason) {
`This cookie didn't specify a SameSite attribute when it was stored and was defaulted to "SameSite=Lax" and broke the same rules specified in the SameSiteLax value. The cookie had to have been set with "SameSite=None" to enable third-party usage.`; `This cookie didn't specify a SameSite attribute when it was stored and was defaulted to "SameSite=Lax" and broke the same rules specified in the SameSiteLax value. The cookie had to have been set with "SameSite=None" to enable third-party usage.`;
case Protocol.Network.CookieBlockedReason.SameSiteNoneInsecure: case Protocol.Network.CookieBlockedReason.SameSiteNoneInsecure:
return ls return ls
`This cookie had the "SameSite=None" attribute and the connection was not secure. Cookies without SameSite restrictions must be sent over a secure connection.`; `This cookie had the "SameSite=None" attribute but was not marked "Secure". Cookies without SameSite restrictions must be marked "Secure" and sent over a secure connection.`;
case Protocol.Network.CookieBlockedReason.UserPreferences: case Protocol.Network.CookieBlockedReason.UserPreferences:
return ls`This cookie was not sent due to user preferences.`; return ls`This cookie was not sent due to user preferences.`;
case Protocol.Network.CookieBlockedReason.UnknownError: case Protocol.Network.CookieBlockedReason.UnknownError:
......
...@@ -3,6 +3,9 @@ ...@@ -3,6 +3,9 @@
<message name="IDS_DEVTOOLS_021aa7730980fe55529e460ee1367179" desc="Tooltip to explain why a cookie was blocked"> <message name="IDS_DEVTOOLS_021aa7730980fe55529e460ee1367179" desc="Tooltip to explain why a cookie was blocked">
This cookie had the &quot;SameSite=Extended&quot; attribute and the request was made on a different site. The different site is outside of the cookie&apos;s trusted first-party set. This cookie had the &quot;SameSite=Extended&quot; attribute and the request was made on a different site. The different site is outside of the cookie&apos;s trusted first-party set.
</message> </message>
<message name="IDS_DEVTOOLS_04608e209233c72a33b9a80e8ff2bd58" desc="Tooltip to explain why a cookie was blocked">
This cookie had the &quot;SameSite=None&quot; attribute but was not marked &quot;Secure&quot;. Cookies without SameSite restrictions must be marked &quot;Secure&quot; and sent over a secure connection.
</message>
<message name="IDS_DEVTOOLS_07553a11db31a4433684be32cc4716e3" desc="Text in Network Manager"> <message name="IDS_DEVTOOLS_07553a11db31a4433684be32cc4716e3" desc="Text in Network Manager">
Cross-Origin Read Blocking (CORB) blocked cross-origin response <ph name="NETWORKREQUEST_URL__">$1s<ex>https://example.com</ex></ph> with MIME type <ph name="NETWORKREQUEST_MIMETYPE">$2s<ex>application</ex></ph>. See https://www.chromestatus.com/feature/5629709824032768 for more details. Cross-Origin Read Blocking (CORB) blocked cross-origin response <ph name="NETWORKREQUEST_URL__">$1s<ex>https://example.com</ex></ph> with MIME type <ph name="NETWORKREQUEST_MIMETYPE">$2s<ex>application</ex></ph>. See https://www.chromestatus.com/feature/5629709824032768 for more details.
</message> </message>
...@@ -204,9 +207,6 @@ ...@@ -204,9 +207,6 @@
<message name="IDS_DEVTOOLS_794f64c7f20487f6e13679201deeab3d" desc="Text in DOMDebugger Model"> <message name="IDS_DEVTOOLS_794f64c7f20487f6e13679201deeab3d" desc="Text in DOMDebugger Model">
Picture-in-Picture Picture-in-Picture
</message> </message>
<message name="IDS_DEVTOOLS_7a3a5ae00a1133b1042cf4edf671736a" desc="Tooltip to explain why a cookie was blocked">
This cookie had the &quot;SameSite=None&quot; attribute and the connection was not secure. Cookies without SameSite restrictions must be sent over a secure connection.
</message>
<message name="IDS_DEVTOOLS_7c2bc755363ab11a1611bfa369654ff8" desc="Title of a setting under the Rendering category that can be invoked through the Command Menu"> <message name="IDS_DEVTOOLS_7c2bc755363ab11a1611bfa369654ff8" desc="Title of a setting under the Rendering category that can be invoked through the Command Menu">
Show frames per second (FPS) meter Show frames per second (FPS) meter
</message> </message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment