Commit 16d6164b authored by Sky Malice's avatar Sky Malice Committed by Commit Bot

[Feed] Wrap comments at 100 characters.

Change-Id: I35da57c3825753bf348b8388c087249bdc928834
Reviewed-on: https://chromium-review.googlesource.com/1089639Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565060}
parent a711806f
...@@ -154,8 +154,7 @@ public class FeedNewTabPage extends BasicNativePage { ...@@ -154,8 +154,7 @@ public class FeedNewTabPage extends BasicNativePage {
stream.getView().setBackgroundColor(Color.WHITE); stream.getView().setBackgroundColor(Color.WHITE);
mRootView.addView(stream.getView()); mRootView.addView(stream.getView());
// TODO(skym): This is a work around for outstanding Feed bug. Should be // TODO(skym): This is a work around for outstanding Feed bug.
// removed on next DEPS roll.
stream.triggerRefresh(); stream.triggerRefresh();
// TODO(https://crbug.com/803317): Call appropriate lifecycle methods. // TODO(https://crbug.com/803317): Call appropriate lifecycle methods.
......
...@@ -40,10 +40,9 @@ public class FeedSchedulerBridge implements SchedulerApi { ...@@ -40,10 +40,9 @@ public class FeedSchedulerBridge implements SchedulerApi {
} }
/* /*
* Sets our copy of the RequestManager. Should be done as early as possible, * Sets our copy of the RequestManager. Should be done as early as possible, as the scheduler
* as the scheduler will be unable to trigger refreshes until after it has a * will be unable to trigger refreshes until after it has a reference to a RequestManager. When
* reference to a RequestManager. When this is called, it is assumed that * this is called, it is assumed that the RequestManager is initialized and can be used.
* the RequestManager is initialized and can be used.
* *
* @param requestManager The interface that allows us make refresh requests. * @param requestManager The interface that allows us make refresh requests.
*/ */
...@@ -59,12 +58,11 @@ public class FeedSchedulerBridge implements SchedulerApi { ...@@ -59,12 +58,11 @@ public class FeedSchedulerBridge implements SchedulerApi {
int nativeBehavior = nativeShouldSessionRequestData(mNativeBridge, int nativeBehavior = nativeShouldSessionRequestData(mNativeBridge,
sessionManagerState.hasContent, sessionManagerState.contentCreationDateTimeMs, sessionManagerState.hasContent, sessionManagerState.contentCreationDateTimeMs,
sessionManagerState.hasOutstandingRequest); sessionManagerState.hasOutstandingRequest);
// If this breaks, it is because SchedulerApi.RequestBehavior and the // If this breaks, it is because SchedulerApi.RequestBehavior and the NativeRequestBehavior
// NativeRequestBehavior defined in feed_scheduler_host.h have diverged. // defined in feed_scheduler_host.h have diverged. If this happens during a feed DEPS roll,
// If this happens during a feed DEPS roll, it likely means that the // it likely means that the native side needs to be updated. Note that this will not catch
// native side needs to be updated. Note that this will not catch new // new values and should handle value changes. Only removals/renames will cause compile
// values and should handle value changes. Only removals/renames will // failures.
// cause compile failures.
switch (nativeBehavior) { switch (nativeBehavior) {
case NativeRequestBehavior.REQUEST_WITH_WAIT: case NativeRequestBehavior.REQUEST_WITH_WAIT:
return SchedulerApi.RequestBehavior.REQUEST_WITH_WAIT; return SchedulerApi.RequestBehavior.REQUEST_WITH_WAIT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment