Commit 16df0491 authored by Antonio Gomes's avatar Antonio Gomes Committed by Commit Bot

Rename content's UserMediaRequest to UserMediaRequestInfo

... so it does not collide with blink's conamed class, when
these files get Onion soup'ed.

BUG=704136
R=guidou@chromium.org

Change-Id: I93961b646cb79ff29d54a10f5114bb4866e029f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731450
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683236}
parent 5db196cf
...@@ -51,7 +51,8 @@ void UpdateAPICount(blink::WebUserMediaRequest::MediaType media_type) { ...@@ -51,7 +51,8 @@ void UpdateAPICount(blink::WebUserMediaRequest::MediaType media_type) {
} // namespace } // namespace
UserMediaClientImpl::Request::Request(std::unique_ptr<UserMediaRequest> request) UserMediaClientImpl::Request::Request(
std::unique_ptr<UserMediaRequestInfo> request)
: user_media_request_(std::move(request)) { : user_media_request_(std::move(request)) {
DCHECK(user_media_request_); DCHECK(user_media_request_);
DCHECK(apply_constraints_request_.IsNull()); DCHECK(apply_constraints_request_.IsNull());
...@@ -95,7 +96,7 @@ UserMediaClientImpl::Request& UserMediaClientImpl::Request::operator=( ...@@ -95,7 +96,7 @@ UserMediaClientImpl::Request& UserMediaClientImpl::Request::operator=(
Request&& other) = default; Request&& other) = default;
UserMediaClientImpl::Request::~Request() = default; UserMediaClientImpl::Request::~Request() = default;
std::unique_ptr<UserMediaRequest> std::unique_ptr<UserMediaRequestInfo>
UserMediaClientImpl::Request::MoveUserMediaRequest() { UserMediaClientImpl::Request::MoveUserMediaRequest() {
return std::move(user_media_request_); return std::move(user_media_request_);
} }
...@@ -171,8 +172,9 @@ void UserMediaClientImpl::RequestUserMedia( ...@@ -171,8 +172,9 @@ void UserMediaClientImpl::RequestUserMedia(
web_request.OwnerDocument().IsNull() web_request.OwnerDocument().IsNull()
? nullptr ? nullptr
: web_request.OwnerDocument().GetFrame()); : web_request.OwnerDocument().GetFrame());
std::unique_ptr<UserMediaRequest> request_info = std::unique_ptr<UserMediaRequestInfo> request_info =
std::make_unique<UserMediaRequest>(request_id, web_request, user_gesture); std::make_unique<UserMediaRequestInfo>(request_id, web_request,
user_gesture);
pending_request_infos_.push_back(Request(std::move(request_info))); pending_request_infos_.push_back(Request(std::move(request_info)));
if (!is_processing_request_) if (!is_processing_request_)
MaybeProcessNextRequestInfo(); MaybeProcessNextRequestInfo();
...@@ -252,7 +254,7 @@ void UserMediaClientImpl::CancelUserMediaRequest( ...@@ -252,7 +254,7 @@ void UserMediaClientImpl::CancelUserMediaRequest(
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
{ {
// TODO(guidou): Remove this conditional logging. https://crbug.com/764293 // TODO(guidou): Remove this conditional logging. https://crbug.com/764293
UserMediaRequest* request = user_media_processor_->CurrentRequest(); UserMediaRequestInfo* request = user_media_processor_->CurrentRequest();
if (request && request->web_request == web_request) { if (request && request->web_request == web_request) {
blink::WebRtcLogMessage(base::StringPrintf( blink::WebRtcLogMessage(base::StringPrintf(
"UMCI::CancelUserMediaRequest. request_id=%d", request->request_id)); "UMCI::CancelUserMediaRequest. request_id=%d", request->request_id));
......
...@@ -69,16 +69,16 @@ class CONTENT_EXPORT UserMediaClientImpl : public RenderFrameObserver, ...@@ -69,16 +69,16 @@ class CONTENT_EXPORT UserMediaClientImpl : public RenderFrameObserver,
private: private:
class Request { class Request {
public: public:
explicit Request(std::unique_ptr<UserMediaRequest> request); explicit Request(std::unique_ptr<UserMediaRequestInfo> request);
explicit Request(const blink::WebApplyConstraintsRequest& request); explicit Request(const blink::WebApplyConstraintsRequest& request);
explicit Request(const blink::WebMediaStreamTrack& request); explicit Request(const blink::WebMediaStreamTrack& request);
Request(Request&& other); Request(Request&& other);
Request& operator=(Request&& other); Request& operator=(Request&& other);
~Request(); ~Request();
std::unique_ptr<UserMediaRequest> MoveUserMediaRequest(); std::unique_ptr<UserMediaRequestInfo> MoveUserMediaRequest();
UserMediaRequest* user_media_request() const { UserMediaRequestInfo* user_media_request() const {
return user_media_request_.get(); return user_media_request_.get();
} }
const blink::WebApplyConstraintsRequest& apply_constraints_request() const { const blink::WebApplyConstraintsRequest& apply_constraints_request() const {
...@@ -95,7 +95,7 @@ class CONTENT_EXPORT UserMediaClientImpl : public RenderFrameObserver, ...@@ -95,7 +95,7 @@ class CONTENT_EXPORT UserMediaClientImpl : public RenderFrameObserver,
bool IsStopTrack() const { return !web_track_to_stop_.IsNull(); } bool IsStopTrack() const { return !web_track_to_stop_.IsNull(); }
private: private:
std::unique_ptr<UserMediaRequest> user_media_request_; std::unique_ptr<UserMediaRequestInfo> user_media_request_;
blink::WebApplyConstraintsRequest apply_constraints_request_; blink::WebApplyConstraintsRequest apply_constraints_request_;
blink::WebMediaStreamTrack web_track_to_stop_; blink::WebMediaStreamTrack web_track_to_stop_;
}; };
......
...@@ -209,7 +209,7 @@ std::vector<blink::VideoInputDeviceCapabilities> ToVideoInputDeviceCapabilities( ...@@ -209,7 +209,7 @@ std::vector<blink::VideoInputDeviceCapabilities> ToVideoInputDeviceCapabilities(
} // namespace } // namespace
UserMediaRequest::UserMediaRequest( UserMediaRequestInfo::UserMediaRequestInfo(
int request_id, int request_id,
const blink::WebUserMediaRequest& web_request, const blink::WebUserMediaRequest& web_request,
bool is_processing_user_gesture) bool is_processing_user_gesture)
...@@ -231,7 +231,7 @@ class UserMediaProcessor::RequestInfo ...@@ -231,7 +231,7 @@ class UserMediaProcessor::RequestInfo
GENERATED, GENERATED,
}; };
explicit RequestInfo(std::unique_ptr<UserMediaRequest> request); explicit RequestInfo(std::unique_ptr<UserMediaRequestInfo> request);
void StartAudioTrack(const blink::WebMediaStreamTrack& track, void StartAudioTrack(const blink::WebMediaStreamTrack& track,
bool is_pending); bool is_pending);
...@@ -247,7 +247,7 @@ class UserMediaProcessor::RequestInfo ...@@ -247,7 +247,7 @@ class UserMediaProcessor::RequestInfo
MediaStreamRequestResult result, MediaStreamRequestResult result,
const blink::WebString& result_name); const blink::WebString& result_name);
UserMediaRequest* request() { return request_.get(); } UserMediaRequestInfo* request() { return request_.get(); }
int request_id() const { return request_->request_id; } int request_id() const { return request_->request_id; }
State state() const { return state_; } State state() const { return state_; }
...@@ -328,7 +328,7 @@ class UserMediaProcessor::RequestInfo ...@@ -328,7 +328,7 @@ class UserMediaProcessor::RequestInfo
// that |this| might be deleted when the function returns. // that |this| might be deleted when the function returns.
void CheckAllTracksStarted(); void CheckAllTracksStarted();
std::unique_ptr<UserMediaRequest> request_; std::unique_ptr<UserMediaRequestInfo> request_;
State state_ = State::NOT_SENT_FOR_GENERATION; State state_ = State::NOT_SENT_FOR_GENERATION;
blink::AudioCaptureSettings audio_capture_settings_; blink::AudioCaptureSettings audio_capture_settings_;
bool is_audio_content_capture_ = false; bool is_audio_content_capture_ = false;
...@@ -352,7 +352,7 @@ class UserMediaProcessor::RequestInfo ...@@ -352,7 +352,7 @@ class UserMediaProcessor::RequestInfo
// TODO(guidou): Initialize request_result_name_ as a null blink::WebString. // TODO(guidou): Initialize request_result_name_ as a null blink::WebString.
// https://crbug.com/764293 // https://crbug.com/764293
UserMediaProcessor::RequestInfo::RequestInfo( UserMediaProcessor::RequestInfo::RequestInfo(
std::unique_ptr<UserMediaRequest> request) std::unique_ptr<UserMediaRequestInfo> request)
: request_(std::move(request)), : request_(std::move(request)),
security_origin_(url::Origin(request_->web_request.GetSecurityOrigin())), security_origin_(url::Origin(request_->web_request.GetSecurityOrigin())),
request_result_name_("") {} request_result_name_("") {}
...@@ -464,12 +464,12 @@ UserMediaProcessor::~UserMediaProcessor() { ...@@ -464,12 +464,12 @@ UserMediaProcessor::~UserMediaProcessor() {
StopAllProcessing(); StopAllProcessing();
} }
UserMediaRequest* UserMediaProcessor::CurrentRequest() { UserMediaRequestInfo* UserMediaProcessor::CurrentRequest() {
return current_request_info_ ? current_request_info_->request() : nullptr; return current_request_info_ ? current_request_info_->request() : nullptr;
} }
void UserMediaProcessor::ProcessRequest( void UserMediaProcessor::ProcessRequest(
std::unique_ptr<UserMediaRequest> request, std::unique_ptr<UserMediaRequestInfo> request,
base::OnceClosure callback) { base::OnceClosure callback) {
DCHECK(!request_completed_cb_); DCHECK(!request_completed_cb_);
DCHECK(!current_request_info_); DCHECK(!current_request_info_);
......
...@@ -45,10 +45,10 @@ class RenderFrameImpl; ...@@ -45,10 +45,10 @@ class RenderFrameImpl;
// TODO(guidou): Add |request_id| and |is_processing_user_gesture| to // TODO(guidou): Add |request_id| and |is_processing_user_gesture| to
// blink::WebUserMediaRequest and remove this struct. // blink::WebUserMediaRequest and remove this struct.
struct UserMediaRequest { struct UserMediaRequestInfo {
UserMediaRequest(int request_id, UserMediaRequestInfo(int request_id,
const blink::WebUserMediaRequest& web_request, const blink::WebUserMediaRequest& web_request,
bool is_processing_user_gesture); bool is_processing_user_gesture);
const int request_id; const int request_id;
const blink::WebUserMediaRequest web_request; const blink::WebUserMediaRequest web_request;
const bool is_processing_user_gesture; const bool is_processing_user_gesture;
...@@ -78,13 +78,13 @@ class CONTENT_EXPORT UserMediaProcessor ...@@ -78,13 +78,13 @@ class CONTENT_EXPORT UserMediaProcessor
// during the execution of a task on the main thread unless ProcessRequest or // during the execution of a task on the main thread unless ProcessRequest or
// DeleteWebRequest are invoked. // DeleteWebRequest are invoked.
// TODO(guidou): Remove this method. https://crbug.com/764293 // TODO(guidou): Remove this method. https://crbug.com/764293
UserMediaRequest* CurrentRequest(); UserMediaRequestInfo* CurrentRequest();
// Starts processing |request| in order to create a new MediaStream. When // Starts processing |request| in order to create a new MediaStream. When
// processing of |request| is complete, it notifies by invoking |callback|. // processing of |request| is complete, it notifies by invoking |callback|.
// This method must be called only if there is no request currently being // This method must be called only if there is no request currently being
// processed. // processed.
void ProcessRequest(std::unique_ptr<UserMediaRequest> request, void ProcessRequest(std::unique_ptr<UserMediaRequestInfo> request,
base::OnceClosure callback); base::OnceClosure callback);
// If |web_request| is the request currently being processed, stops processing // If |web_request| is the request currently being processed, stops processing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment