Commit 16e242a1 authored by Jazz Xu's avatar Jazz Xu Committed by Commit Bot

Media Controls: Fix audio controls focus ring.

This CL fixed the issue where the audio controls' focus ring is seem
chopped. Demo video linked in the bug.

Rebaseline some of the test since the shrinking height of buttons in
audio controls will result in some tiny pixel changes.

Bug: 921955
Change-Id: I197cb7c0f29b2bbd5383203f8d7dd8d0b7ee4f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468783Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817725}
parent faadfc48
...@@ -197,7 +197,7 @@ video::-internal-media-controls-picture-in-picture-button { ...@@ -197,7 +197,7 @@ video::-internal-media-controls-picture-in-picture-button {
* controls should be same. * controls should be same.
*/ */
width: 32px; width: 32px;
height: 48px; height: 32px;
min-width: 32px; min-width: 32px;
padding: 0; padding: 0;
border-width: 0; border-width: 0;
...@@ -257,7 +257,7 @@ audio::-webkit-media-controls input[pseudo="-internal-media-controls-overflow-bu ...@@ -257,7 +257,7 @@ audio::-webkit-media-controls input[pseudo="-internal-media-controls-overflow-bu
width: 32px; width: 32px;
height: 32px; height: 32px;
left: 0; left: 0;
top: 8px; top: 0;
border-radius: 16px; border-radius: 16px;
} }
...@@ -478,6 +478,7 @@ video::-webkit-media-controls-volume-control-container.closed { ...@@ -478,6 +478,7 @@ video::-webkit-media-controls-volume-control-container.closed {
*/ */
video::-webkit-media-controls.audio-only div[pseudo="-webkit-media-controls-volume-control-container" i], video::-webkit-media-controls.audio-only div[pseudo="-webkit-media-controls-volume-control-container" i],
audio::-webkit-media-controls-volume-control-container { audio::-webkit-media-controls-volume-control-container {
height: 32px;
min-width: 100px; min-width: 100px;
} }
...@@ -510,7 +511,7 @@ audio::-webkit-media-controls-volume-control-hover-background { ...@@ -510,7 +511,7 @@ audio::-webkit-media-controls-volume-control-hover-background {
height: 32px; height: 32px;
width: 100px; width: 100px;
border-radius: 16px; border-radius: 16px;
top: 8px; top: 0;
right: 0; right: 0;
opacity: .06; opacity: .06;
} }
...@@ -631,8 +632,8 @@ video::-webkit-media-controls-timeline:disabled { ...@@ -631,8 +632,8 @@ video::-webkit-media-controls-timeline:disabled {
audio::-webkit-media-controls-timeline, audio::-webkit-media-controls-timeline,
video::-webkit-media-controls.audio-only [pseudo="-webkit-media-controls-timeline"] { video::-webkit-media-controls.audio-only [pseudo="-webkit-media-controls-timeline"] {
padding-top: 26px; padding-top: 14px;
padding-bottom: 26px; padding-bottom: 14px;
} }
video::-webkit-media-controls-timeline { video::-webkit-media-controls-timeline {
...@@ -818,6 +819,11 @@ video::-webkit-media-controls.sizing-large input[pseudo="-webkit-media-controls- ...@@ -818,6 +819,11 @@ video::-webkit-media-controls.sizing-large input[pseudo="-webkit-media-controls-
padding: 30px 0; /* (64px button panel height - 4px slider height) / 2 */ padding: 30px 0; /* (64px button panel height - 4px slider height) / 2 */
} }
video::-webkit-media-controls.audio-only input[pseudo="-webkit-media-controls-volume-slider" i],
audio::-webkit-media-controls-volume-slider {
padding: 14px 0; /* (32px button panel height - 4px slider height) / 2 */
}
/** /**
* Time Display * Time Display
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment