Commit 16e76d33 authored by Jose Dapena Paz's avatar Jose Dapena Paz Committed by Commit Bot

Make SharedBitmapIdRegistration move constructor/assignment noexcept

blink::ImageLayerBridge::RegisteredBitmap declares now its move constructor and
assignment operator as noexcept with default implementation. This requires all its
parts to be move constructible and assignable. SharedBitmapIdRegistration was
missing noexcept declarations.

Bug: 819294
Change-Id: I1304e4666141355c61780d69d1669b5c49df4baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768616Reviewed-by: default avatarenne <enne@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#693062}
parent 618fe8e5
......@@ -21,10 +21,10 @@ SharedBitmapIdRegistration::~SharedBitmapIdRegistration() {
}
SharedBitmapIdRegistration::SharedBitmapIdRegistration(
SharedBitmapIdRegistration&&) = default;
SharedBitmapIdRegistration&&) noexcept = default;
SharedBitmapIdRegistration& SharedBitmapIdRegistration::operator=(
SharedBitmapIdRegistration&& other) {
SharedBitmapIdRegistration&& other) noexcept {
if (layer_ptr_)
layer_ptr_->UnregisterSharedBitmapId(id_);
layer_ptr_ = std::move(other.layer_ptr_);
......
......@@ -50,12 +50,12 @@ class CC_EXPORT SharedBitmapIdRegistration {
public:
SharedBitmapIdRegistration();
SharedBitmapIdRegistration(const SharedBitmapIdRegistration&) = delete;
SharedBitmapIdRegistration(SharedBitmapIdRegistration&&);
SharedBitmapIdRegistration(SharedBitmapIdRegistration&&) noexcept;
~SharedBitmapIdRegistration();
SharedBitmapIdRegistration& operator=(const SharedBitmapIdRegistration&) =
delete;
SharedBitmapIdRegistration& operator=(SharedBitmapIdRegistration&&);
SharedBitmapIdRegistration& operator=(SharedBitmapIdRegistration&&) noexcept;
private:
// Constructed by TextureLayer only, then held by the client as long
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment