Commit 16f2b482 authored by Eric Willigers's avatar Eric Willigers Committed by Chromium LUCI CQ

Direct Sockets: Use counters for TCPSocket members

We add use counters for
- close()
- readable
- writable
- remoteAddress
- remotePort



Bug: 905818
Change-Id: I02539b29d3c1035642ba9200651ac15135eb58c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636634
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarGlen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844693}
parent 03ad8ab3
...@@ -3097,6 +3097,11 @@ enum WebFeature { ...@@ -3097,6 +3097,11 @@ enum WebFeature {
kAddressSpaceUnknownNonSecureContextNavigatedToPrivate = 3772, kAddressSpaceUnknownNonSecureContextNavigatedToPrivate = 3772,
kRTCPeerConnectionSdpSemanticsPlanB = 3773, kRTCPeerConnectionSdpSemanticsPlanB = 3773,
kFetchRespondWithNoResponseWithUsedRequestBody = 3774, kFetchRespondWithNoResponseWithUsedRequestBody = 3774,
kV8TCPSocket_Close_Method = 3775,
kV8TCPSocket_Readable_AttributeGetter = 3776,
kV8TCPSocket_Writable_AttributeGetter = 3777,
kV8TCPSocket_RemoteAddress_AttributeGetter = 3778,
kV8TCPSocket_RemotePort_AttributeGetter = 3779,
// Add new features immediately above this line. Don't change assigned // Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots. // numbers of any item, and don't reuse removed slots.
......
...@@ -9,14 +9,11 @@ ...@@ -9,14 +9,11 @@
RuntimeEnabled=DirectSockets, RuntimeEnabled=DirectSockets,
SecureContext SecureContext
] interface TCPSocket { ] interface TCPSocket {
// TODO(crbug.com/905818): Add support for sending, receiving [RaisesException, CallWith=ScriptState, Measure]
// TODO(crbug.com/905818): Add measurement
[RaisesException, CallWith=ScriptState]
Promise<void> close(); Promise<void> close();
readonly attribute DOMString remoteAddress; [Measure] readonly attribute DOMString remoteAddress;
readonly attribute unsigned short remotePort; [Measure] readonly attribute unsigned short remotePort;
readonly attribute ReadableStream readable; [Measure] readonly attribute ReadableStream readable;
readonly attribute WritableStream writable; [Measure] readonly attribute WritableStream writable;
}; };
...@@ -31000,6 +31000,11 @@ Called by update_use_counter_feature_enum.py.--> ...@@ -31000,6 +31000,11 @@ Called by update_use_counter_feature_enum.py.-->
label="AddressSpaceUnknownNonSecureContextNavigatedToPrivate"/> label="AddressSpaceUnknownNonSecureContextNavigatedToPrivate"/>
<int value="3773" label="RTCPeerConnectionSdpSemanticsPlanB"/> <int value="3773" label="RTCPeerConnectionSdpSemanticsPlanB"/>
<int value="3774" label="FetchRespondWithNoResponseWithUsedRequestBody"/> <int value="3774" label="FetchRespondWithNoResponseWithUsedRequestBody"/>
<int value="3775" label="V8TCPSocket_Close_Method"/>
<int value="3776" label="V8TCPSocket_Readable_AttributeGetter"/>
<int value="3777" label="V8TCPSocket_Writable_AttributeGetter"/>
<int value="3778" label="V8TCPSocket_RemoteAddress_AttributeGetter"/>
<int value="3779" label="V8TCPSocket_RemotePort_AttributeGetter"/>
</enum> </enum>
<enum name="FeaturePolicyAllowlistType"> <enum name="FeaturePolicyAllowlistType">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment