Commit 16fa1acb authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Add FileVersionInfoTest.NoVersionInfo

Test to make sure no_version_info.dll, which has no version info, causes
base::FileVersionInfo::CreateFileVersionInfo() and
CreateFileVersionInfoForModule() to return nullptr.

no_version_info.dll is just an one-off component build of pdfium.dll,
with everything stripped out.

Change-Id: I3e4b527f1d2f52dcec55c2c38af369a651608175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838268Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702886}
parent 91a2f16b
......@@ -156,3 +156,11 @@ TYPED_TEST(FileVersionInfoTest, CustomProperties) {
EXPECT_EQ(base::Version(std::vector<uint32_t>{1, 0, 0, 1}),
version_info_win->GetFileVersion());
}
TYPED_TEST(FileVersionInfoTest, NoVersionInfo) {
FilePath dll_path = GetTestDataPath();
dll_path = dll_path.AppendASCII("no_version_info.dll");
TypeParam factory(dll_path);
ASSERT_FALSE(factory.Create());
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment