Commit 170c9a46 authored by Bo's avatar Bo Committed by Commit Bot

Revert "net: DumpWithoutCrashing for invalid header name"

This reverts commit 1c3c18d5.

Reason for revert: No longer needed after getting useful reports.

Original change's description:
> net: DumpWithoutCrashing for invalid header name
>
> Add a temporary DumpWithoutCrashing for when an invalid header key is
> set. This is to debug crbug.com/1028189 where a header key fails to
> deserialize correctly.
>
> Bug: 1028189
> Change-Id: I8848f1b4b78363b56babd787d73f24f8c11dec3c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401278
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805369}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1028189
Bug: 1129397
Change-Id: I83a31e47d891937458e7f9a69cdf9ef58704fddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416868Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807968}
parent 7f334d30
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
#include <utility> #include <utility>
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/notreached.h" #include "base/notreached.h"
#include "base/strings/strcat.h" #include "base/strings/strcat.h"
...@@ -107,10 +106,6 @@ void HttpRequestHeaders::Clear() { ...@@ -107,10 +106,6 @@ void HttpRequestHeaders::Clear() {
void HttpRequestHeaders::SetHeader(const base::StringPiece& key, void HttpRequestHeaders::SetHeader(const base::StringPiece& key,
const base::StringPiece& value) { const base::StringPiece& value) {
// TODO(crbug.com/1028189): Adding temporarily to debug crbug.com/1028189.
if (!HttpUtil::IsValidHeaderName(key)) {
base::debug::DumpWithoutCrashing();
}
// Invalid header names or values could mean clients can attach // Invalid header names or values could mean clients can attach
// browser-internal headers. // browser-internal headers.
DCHECK(HttpUtil::IsValidHeaderName(key)) << key; DCHECK(HttpUtil::IsValidHeaderName(key)) << key;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment