Commit 171ae7a0 authored by Hongbo Song's avatar Hongbo Song Committed by Commit Bot

1. Stop observing FSD when the delegate_ of layer_tree_view is null.

2. Stop observing FSD when the local_root_ or the client of local_root_ is null.

Once |LayerTreeView::Disconnect()| is called to shutdown the compositor, the delegate_ will be null. We should not observe FSD after that.

Change-Id: Ia0d0e27f6d7db0d2c452b8951191424884f5585a
Bug: 922980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218230
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772398}
parent e70822a1
...@@ -465,6 +465,9 @@ void WebFrameWidgetBase::DidCommitAndDrawCompositorFrame() { ...@@ -465,6 +465,9 @@ void WebFrameWidgetBase::DidCommitAndDrawCompositorFrame() {
void WebFrameWidgetBase::DidObserveFirstScrollDelay( void WebFrameWidgetBase::DidObserveFirstScrollDelay(
base::TimeDelta first_scroll_delay) { base::TimeDelta first_scroll_delay) {
if (!LocalRoot() || !(LocalRoot()->Client())) {
return;
}
LocalRoot()->Client()->DidObserveFirstScrollDelay(first_scroll_delay); LocalRoot()->Client()->DidObserveFirstScrollDelay(first_scroll_delay);
} }
......
...@@ -338,6 +338,9 @@ void LayerTreeView::NotifyThroughputTrackerResults( ...@@ -338,6 +338,9 @@ void LayerTreeView::NotifyThroughputTrackerResults(
void LayerTreeView::DidObserveFirstScrollDelay( void LayerTreeView::DidObserveFirstScrollDelay(
base::TimeDelta first_scroll_delay) { base::TimeDelta first_scroll_delay) {
if (!delegate_) {
return;
}
delegate_->DidObserveFirstScrollDelay(first_scroll_delay); delegate_->DidObserveFirstScrollDelay(first_scroll_delay);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment