drive: Remove the remaining mentions of "feed"

The term "feed" is irrelevant with Drive API, hence should not be
used in code.

BUG=165395
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16072024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203955 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/chromeos/drive/change_list_processor_unittest.cc

@@ -466,7 +466,7 @@ TEST_F(ChangeListProcessorTest, DeltaAddAndDeleteFileFromExistingDirectory) {
 }
 
 TEST_F(ChangeListProcessorTest, DeltaAddFileToNewButDeletedDirectory) {
-  // This feed contains the following updates:
+  // This file contains the following updates:
   // 1) A new PDF file is added to a new directory
   // 2) but the new directory is marked "deleted" (i.e. moved to Trash)
   // Hence, the PDF file should be just ignored.

chrome/browser/chromeos/drive/file_system.h

@@ -253,8 +253,8 @@ class FileSystem : public FileSystemInterface,
       google_apis::GDataErrorCode status,
       scoped_ptr<google_apis::AboutResource> about_resource);
 
-  // Callback for handling results of ReloadFeedFromServerIfNeeded() initiated
-  // from CheckForUpdates().
+  // Part of CheckForUpdates(). Called when
+  // ChangeListLoader::CheckForUpdates() is complete.
   void OnUpdateChecked(FileError error);
 
   // Changes state of hosted documents visibility, triggers directory refresh.

chrome/browser/chromeos/drive/file_system_unittest.cc

@@ -64,11 +64,7 @@ void AsyncInitializationCallback(
 class FileSystemTest : public testing::Test {
  protected:
   FileSystemTest()
-      : ui_thread_(content::BrowserThread::UI, &message_loop_),
-        // |root_feed_changestamp_| should be set to the largest changestamp in
-        // about resource feed. But we fake it by some non-zero positive
-        // increasing value.  See |LoadFeed()|.
-        root_feed_changestamp_(1) {
+      : ui_thread_(content::BrowserThread::UI, &message_loop_) {
   }
 
   virtual void SetUp() OVERRIDE {
@@ -139,8 +135,8 @@ class FileSystemTest : public testing::Test {
     profile_.reset(NULL);
   }
 
-  // Loads test json file as root ("/drive") element.
-  bool LoadRootFeedDocument() {
+  // Loads the full resource list via FakeDriveService.
+  bool LoadFullResourceList() {
     FileError error = FILE_ERROR_FAILED;
     file_system_->change_list_loader()->LoadIfNeeded(
         DirectoryFetchInfo(),
@@ -342,8 +338,6 @@ class FileSystemTest : public testing::Test {
   scoped_ptr<FakeFreeDiskSpaceGetter> fake_free_disk_space_getter_;
   scoped_ptr<StrictMock<MockCacheObserver> > mock_cache_observer_;
   scoped_ptr<StrictMock<MockDirectoryChangeObserver> > mock_directory_observer_;
-
-  int root_feed_changestamp_;
 };
 
 TEST_F(FileSystemTest, DuplicatedAsyncInitialization) {
@@ -551,14 +545,15 @@ TEST_F(FileSystemTest, ReadDirectoryByPath_NonRootDirectory) {
   EXPECT_EQ(3U, entries->size());
 }
 
-TEST_F(FileSystemTest, CachedFeedLoadingThenServerFeedLoading) {
+TEST_F(FileSystemTest, LoadFileSystemFromUpToDateCache) {
   ASSERT_TRUE(SetUpTestFileSystem(USE_SERVER_TIMESTAMP));
 
   // Kicks loading of cached file system and query for server update.
   EXPECT_TRUE(ReadDirectoryByPathSync(util::GetDriveMyDriveRootPath()));
 
-  // SetUpTestFileSystem and "account_metadata.json" have the same changestamp,
-  // so no request for new feeds (i.e., call to GetResourceList) should happen.
+  // SetUpTestFileSystem and "account_metadata.json" have the same
+  // changestamp (i.e. the local metadata is up-to-date), so no request for
+  // new resource list (i.e., call to GetResourceList) should happen.
   EXPECT_EQ(1, fake_drive_service_->about_resource_load_count());
   EXPECT_EQ(0, fake_drive_service_->resource_list_load_count());
 
@@ -570,11 +565,12 @@ TEST_F(FileSystemTest, CachedFeedLoadingThenServerFeedLoading) {
   EXPECT_EQ(2, fake_drive_service_->about_resource_load_count());
 }
 
-TEST_F(FileSystemTest, OfflineCachedFeedLoading) {
+TEST_F(FileSystemTest, LoadFileSystemFromCacheWhileOffline) {
   ASSERT_TRUE(SetUpTestFileSystem(USE_OLD_TIMESTAMP));
 
-  // Make GetResourceList fail for simulating offline situation. This will leave
-  // the file system "loaded from cache, but not synced with server" state.
+  // Make GetResourceList fail for simulating offline situation. This will
+  // leave the file system "loaded from cache, but not synced with server"
+  // state.
   fake_drive_service_->set_offline(true);
 
   // Kicks loading of cached file system and query for server update.
@@ -649,8 +645,8 @@ TEST_F(FileSystemTest, GetResourceEntryNonExistentWhileRefreshing) {
 }
 
 TEST_F(FileSystemTest, CreateDirectoryByImplicitLoad) {
-  // Intentionally *not* calling LoadRootFeedDocument(), for testing that
-  // CreateDirectory ensures feed loading before it runs.
+  // Intentionally *not* calling LoadFullResourceList(), for testing that
+  // CreateDirectory ensures the resource list is loaded before it runs.
 
   base::FilePath existing_directory(
       FILE_PATH_LITERAL("drive/root/Directory 1"));
@@ -667,7 +663,7 @@ TEST_F(FileSystemTest, CreateDirectoryByImplicitLoad) {
 }
 
 TEST_F(FileSystemTest, PinAndUnpin) {
-  ASSERT_TRUE(LoadRootFeedDocument());
+  ASSERT_TRUE(LoadFullResourceList());
 
   base::FilePath file_path(FILE_PATH_LITERAL("drive/root/File 1.txt"));
 
@@ -709,7 +705,7 @@ TEST_F(FileSystemTest, GetAvailableSpace) {
 }
 
 TEST_F(FileSystemTest, RefreshDirectory) {
-  ASSERT_TRUE(LoadRootFeedDocument());
+  ASSERT_TRUE(LoadFullResourceList());
 
   // We'll notify the directory change to the observer.
   EXPECT_CALL(*mock_directory_observer_,
@@ -724,7 +720,7 @@ TEST_F(FileSystemTest, RefreshDirectory) {
 }
 
 TEST_F(FileSystemTest, OpenAndCloseFile) {
-  ASSERT_TRUE(LoadRootFeedDocument());
+  ASSERT_TRUE(LoadFullResourceList());
 
   // The transfered file is cached and the change of "offline available"
   // attribute is notified.
@@ -816,7 +812,7 @@ TEST_F(FileSystemTest, OpenAndCloseFile) {
 
 TEST_F(FileSystemTest, MarkCacheFileAsMountedAndUnmounted) {
   fake_free_disk_space_getter_->set_fake_free_disk_space(kLotsOfSpace);
-  ASSERT_TRUE(LoadRootFeedDocument());
+  ASSERT_TRUE(LoadFullResourceList());
 
   base::FilePath file_in_root(FILE_PATH_LITERAL("drive/root/File 1.txt"));
   scoped_ptr<ResourceEntry> entry(GetResourceEntryByPathSync(file_in_root));