Commit 17502536 authored by Daniel Vogelheim's avatar Daniel Vogelheim Committed by Commit Bot

Origin Policy: Cleanup: Remove runtime-enabled switch.

The previous implementation used both a --feature-enabled and a
--runtime-feature-enabled switch, initializing the latter based on the former,
presumably because it had components in both browser and Blink.
That's redundant.

The current implementation uses the browser switch. All Blink-resident parts
of the code act on whether they receive a policy or not (which would be always
false if the browser switch isn't set).

Bug: 751996
Change-Id: I81f10cc888fd7c29c6c93e727526863216ca6f02
Reviewed-on: https://chromium-review.googlesource.com/1165351Reviewed-by: default avatarMike West <mkwst@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583679}
parent e56095b1
......@@ -343,9 +343,6 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
if (base::FeatureList::IsEnabled(network::features::kOutOfBlinkCORS))
WebRuntimeFeatures::EnableOutOfBlinkCORS(true);
if (base::FeatureList::IsEnabled(features::kOriginPolicy))
WebRuntimeFeatures::EnableOriginPolicy(true);
WebRuntimeFeatures::EnableMediaCastOverlayButton(
base::FeatureList::IsEnabled(media::kMediaCastOverlayButton));
......
......@@ -117,7 +117,6 @@ class WebRuntimeFeatures {
BLINK_PLATFORM_EXPORT static void EnableNotifications(bool);
BLINK_PLATFORM_EXPORT static void EnableOnDeviceChange(bool);
BLINK_PLATFORM_EXPORT static void EnableOrientationEvent(bool);
BLINK_PLATFORM_EXPORT static void EnableOriginPolicy(bool);
BLINK_PLATFORM_EXPORT static void EnableOverflowIconsForMediaControls(bool);
BLINK_PLATFORM_EXPORT static void EnableOverlayScrollbars(bool);
BLINK_PLATFORM_EXPORT static void EnableOutOfBlinkCORS(bool);
......
......@@ -76,10 +76,6 @@ void WebRuntimeFeatures::EnableOriginTrialControlledFeatures(bool enable) {
RuntimeEnabledFeatures::SetOriginTrialControlledFeaturesEnabled(enable);
}
void WebRuntimeFeatures::EnableOriginPolicy(bool enable) {
RuntimeEnabledFeatures::SetOriginPolicyEnabled(enable);
}
void WebRuntimeFeatures::EnableOutOfBlinkCORS(bool enable) {
RuntimeEnabledFeatures::SetOutOfBlinkCORSEnabled(enable);
}
......
......@@ -842,10 +842,6 @@
{
name: "OrientationEvent",
},
{
name: "OriginPolicy",
status: "test",
},
{
name: "OriginTrials",
status: "stable",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment