Commit 178aeca9 authored by Helen Li's avatar Helen Li Committed by Commit Bot

Fix quic certs path in components/cronet/android/test/javaperftests/run.py

The paths to quic certs are changed in r525466.
This CL is to update the run.py to use the new paths.

Bug: 763998
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia55e97118b13d2e7b56fba95c6dca8aeb6ecb3c9
Reviewed-on: https://chromium-review.googlesource.com/848078Reviewed-by: default avatarPaul Jensen <pauljensen@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526720}
parent 15ccae56
...@@ -65,7 +65,6 @@ from devil.android import device_utils ...@@ -65,7 +65,6 @@ from devil.android import device_utils
from devil.android.sdk import intent from devil.android.sdk import intent
import lighttpd_server import lighttpd_server
from pylib import constants from pylib import constants
from pylib import pexpect
from telemetry import android from telemetry import android
from telemetry import benchmark from telemetry import benchmark
from telemetry import benchmark_runner from telemetry import benchmark_runner
...@@ -80,9 +79,9 @@ QUIC_SERVER = os.path.join(BUILD_DIR, 'quic_server') ...@@ -80,9 +79,9 @@ QUIC_SERVER = os.path.join(BUILD_DIR, 'quic_server')
CERT_PATH = os.path.join('net', 'data', 'ssl', 'certificates') CERT_PATH = os.path.join('net', 'data', 'ssl', 'certificates')
QUIC_CERT_DIR = os.path.join(REPOSITORY_ROOT, CERT_PATH) QUIC_CERT_DIR = os.path.join(REPOSITORY_ROOT, CERT_PATH)
QUIC_CERT_HOST = 'test.example.com' QUIC_CERT_HOST = 'test.example.com'
QUIC_CERT_FILENAME = 'quic_%s.crt' % QUIC_CERT_HOST QUIC_CERT_FILENAME = 'quic-chain.pem'
QUIC_CERT = os.path.join(QUIC_CERT_DIR, QUIC_CERT_FILENAME) QUIC_CERT = os.path.join(QUIC_CERT_DIR, QUIC_CERT_FILENAME)
QUIC_KEY = os.path.join(QUIC_CERT_DIR, 'quic_%s.key.pkcs8' % QUIC_CERT_HOST) QUIC_KEY = os.path.join(QUIC_CERT_DIR, 'quic-leaf-cert.key')
APP_APK = os.path.join(BUILD_DIR, 'apks', 'CronetPerfTest.apk') APP_APK = os.path.join(BUILD_DIR, 'apks', 'CronetPerfTest.apk')
APP_PACKAGE = 'org.chromium.net' APP_PACKAGE = 'org.chromium.net'
APP_ACTIVITY = '.CronetPerfTestActivity' APP_ACTIVITY = '.CronetPerfTestActivity'
...@@ -229,15 +228,13 @@ class QuicServer(object): ...@@ -229,15 +228,13 @@ class QuicServer(object):
self._quic_server_doc_root = quic_server_doc_root self._quic_server_doc_root = quic_server_doc_root
def StartupQuicServer(self, device): def StartupQuicServer(self, device):
# Chromium's presubmit checks aren't smart enough to understand cmd = [QUIC_SERVER,
# the redirect done in build/android/pylib/pexpect.py. '--quic_response_cache_dir=%s' % self._quic_server_doc_root,
# pylint: disable=no-member '--certificate_file=%s' % QUIC_CERT,
self._process = pexpect.spawn(QUIC_SERVER, '--key_file=%s' % QUIC_KEY,
['--quic_response_cache_dir=%s' % '--port=%d' % QUIC_PORT]
self._quic_server_doc_root, print "Starting Quic Server", cmd
'--certificate_file=%s' % QUIC_CERT, self._process = subprocess.Popen(cmd)
'--key_file=%s' % QUIC_KEY,
'--port=%d' % QUIC_PORT])
assert self._process != None assert self._process != None
# Wait for quic_server to start serving. # Wait for quic_server to start serving.
waited_s = 0 waited_s = 0
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment