Reland "ONC: Add FTEnabled property to WiFi"

This is a reland of 34f59cac

Turns out it was enough to clobber the WebRTC mac builder.

Original change's description:
> ONC: Add FTEnabled property to WiFi
>
> Support FTEnabled property in ONC.
>
> BUG=791202
> TEST=chromeos_unittests
> TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true
> enables the device to connect to an FT network. Setting
> "FTEnabled":false disables the device from connecting to an FT
> network.
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I2470753fd139505704987e301b18983dc51c5c47
> Reviewed-on: https://chromium-review.googlesource.com/982275
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549366}

TBR=matthewmwang@chromium.org

Bug: 791202
Change-Id: Ia7c49d75e3c7b769e5853e377ef860fef6663abc
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1005114
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549524}

chromeos/network/onc/onc_signature.cc

@@ -225,6 +225,7 @@ const OncFieldSignature wifi_fields[] = {
     {::onc::wifi::kAllowGatewayARPPolling, &kBoolSignature},
     {::onc::wifi::kAutoConnect, &kBoolSignature},
     {::onc::wifi::kEAP, &kEAPSignature},
+    {::onc::wifi::kFTEnabled, &kBoolSignature},
     {::onc::wifi::kHexSSID, &kStringSignature},
     {::onc::wifi::kHiddenSSID, &kBoolSignature},
     {::onc::wifi::kPassphrase, &kStringSignature},

chromeos/network/onc/onc_translation_tables.cc

@@ -140,6 +140,7 @@ const FieldTranslationEntry wifi_fields[] = {
     // { ::onc::wifi::kEAP, shill::kEap*},
     {::onc::wifi::kFrequency, shill::kWifiFrequency},
     {::onc::wifi::kFrequencyList, shill::kWifiFrequencyListProperty},
+    {::onc::wifi::kFTEnabled, shill::kWifiFTEnabled},
     {::onc::wifi::kHexSSID, shill::kWifiHexSsid},
     {::onc::wifi::kHiddenSSID, shill::kWifiHiddenSsid},
     {::onc::wifi::kPassphrase, shill::kPassphraseProperty},

chromeos/test/data/network/shill_wifi_eap_tls.json

@@ -11,5 +11,6 @@
    "Mode": "managed",
    "SaveCredentials": true,
    "SecurityClass": "802_1x",
-   "Type": "wifi"
+   "Type": "wifi",
+   "WiFi.FTEnabled": true
 }

chromeos/test/data/network/shill_wifi_psk.json

@@ -10,5 +10,6 @@
    "WiFi.HiddenSSID": false,
    "WiFi.Frequency": 2412,
    "WiFi.FrequencyList": [2412, 5180],
+   "WiFi.FTEnabled": true,
    "WiFi.RoamThreshold": 20
 }

chromeos/test/data/network/translation_of_shill_wifi_eap_tls.onc

@@ -4,6 +4,7 @@
   "Name": "",
   "WiFi": {
     "Security": "WPA-EAP",
+    "FTEnabled": true,
     "EAP": {
       "ClientCertType": "PKCS11Id",
       "ClientCertPKCS11Id": "1:123456abcdef",

chromeos/test/data/network/valid_wifi_psk.onc

@@ -27,6 +27,7 @@
         "AutoConnect": true,
         "Frequency": 2412,
         "FrequencyList": [2412, 5180],
+        "FTEnabled": true,
         "HexSSID": "4F70656E577274", // "OpenWrt"
         "HiddenSSID": false,
         "Passphrase": "some passphrase",

chromeos/test/data/network/wifi_eap_tls.onc

@@ -4,6 +4,7 @@
   "Name": "WifiEapTls",
   "WiFi": {
     "Security": "WPA-EAP",
+    "FTEnabled": true,
     "EAP": {
       "Outer": "EAP-TLS",
       "Identity": "my_identity",

components/onc/docs/onc_spec.md

@@ -420,6 +420,11 @@ field **WiFi** must be set to an object of type [WiFi](#WiFi-type).
         *WEP-8021X* or *WPA-EAP*, otherwise ignored) - [EAP](#EAP-type)
     * EAP settings.
 
+* **FTEnabled**
+    * (optional, defaults to *false*) - **boolean**
+    * Indicating if the client should attempt to use Fast Transition with the
+    * network.
+
 * **HexSSID**
     * (optional if **SSID** is set, if so defaults to a hex representation of
       **SSID**) - **string**

components/onc/onc_constants.cc

@@ -223,6 +223,7 @@ const char kBSSID[] = "BSSID";
 const char kEAP[] = "EAP";
 const char kFrequency[] = "Frequency";
 const char kFrequencyList[] = "FrequencyList";
+const char kFTEnabled[] = "FTEnabled";
 const char kHexSSID[] = "HexSSID";
 const char kHiddenSSID[] = "HiddenSSID";
 const char kPassphrase[] = "Passphrase";

components/onc/onc_constants.h

@@ -236,6 +236,7 @@ ONC_EXPORT extern const char kBSSID[];
 ONC_EXPORT extern const char kEAP[];
 ONC_EXPORT extern const char kFrequency[];
 ONC_EXPORT extern const char kFrequencyList[];
+ONC_EXPORT extern const char kFTEnabled[];
 ONC_EXPORT extern const char kHexSSID[];
 ONC_EXPORT extern const char kHiddenSSID[];
 ONC_EXPORT extern const char kPassphrase[];

extensions/common/api/networking_private.idl

@@ -644,6 +644,7 @@ namespace networkingPrivate {
     EAPProperties? EAP;
     long? Frequency;
     long[]? FrequencyList;
+    boolean? FTEnabled;
     DOMString? HexSSID;
     boolean? HiddenSSID;
     DOMString? Passphrase;
@@ -660,6 +661,7 @@ namespace networkingPrivate {
     ManagedEAPProperties? EAP;
     long? Frequency;
     long[]? FrequencyList;
+    ManagedBoolean? FTEnabled;
     ManagedDOMString? HexSSID;
     ManagedBoolean? HiddenSSID;
     ManagedDOMString? Passphrase;

third_party/closure_compiler/externs/networking_private.js

@@ -841,6 +841,7 @@ chrome.networkingPrivate.VPNStateProperties;
  *   EAP: (!chrome.networkingPrivate.EAPProperties|undefined),
  *   Frequency: (number|undefined),
  *   FrequencyList: (!Array<number>|undefined),
+ *   FTEnabled: (boolean|undefined),
  *   HexSSID: (string|undefined),
  *   HiddenSSID: (boolean|undefined),
  *   Passphrase: (string|undefined),
@@ -861,6 +862,7 @@ chrome.networkingPrivate.WiFiProperties;
  *   EAP: (!chrome.networkingPrivate.ManagedEAPProperties|undefined),
  *   Frequency: (number|undefined),
  *   FrequencyList: (!Array<number>|undefined),
+ *   FTEnabled: (!chrome.networkingPrivate.ManagedBoolean|undefined),
  *   HexSSID: (!chrome.networkingPrivate.ManagedDOMString|undefined),
  *   HiddenSSID: (!chrome.networkingPrivate.ManagedBoolean|undefined),
  *   Passphrase: (!chrome.networkingPrivate.ManagedDOMString|undefined),