[cleanup] Fix uses of deprecated V8 functions

Pass Isolate* through to StringObject::New, String::Concat,
Value::ToString and StackTrace::GetFrame as the non-Isolate forms are
deprecated.

Change-Id: Ib064eb3beba9493ba67e679118a6369c22cb92cb
Reviewed-on: https://chromium-review.googlesource.com/1150030Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577964}

extensions/renderer/activity_log_converter_strategy.cc

@@ -24,19 +24,23 @@ std::unique_ptr<base::Value> SummarizeV8Value(v8::Isolate* isolate,
       isolate, v8::Isolate::DisallowJavascriptExecutionScope::THROW_ON_FAILURE);
   v8::Local<v8::String> name = v8::String::NewFromUtf8(isolate, "[");
   if (object->IsFunction()) {
-    name =
-        v8::String::Concat(name, v8::String::NewFromUtf8(isolate, "Function"));
+    name = v8::String::Concat(isolate, name,
+                              v8::String::NewFromUtf8(isolate, "Function"));
     v8::Local<v8::Value> fname =
         v8::Local<v8::Function>::Cast(object)->GetName();
     if (fname->IsString() && v8::Local<v8::String>::Cast(fname)->Length()) {
-      name = v8::String::Concat(name, v8::String::NewFromUtf8(isolate, " "));
-      name = v8::String::Concat(name, v8::Local<v8::String>::Cast(fname));
-      name = v8::String::Concat(name, v8::String::NewFromUtf8(isolate, "()"));
+      name = v8::String::Concat(isolate, name,
+                                v8::String::NewFromUtf8(isolate, " "));
+      name =
+          v8::String::Concat(isolate, name, v8::Local<v8::String>::Cast(fname));
+      name = v8::String::Concat(isolate, name,
+                                v8::String::NewFromUtf8(isolate, "()"));
     }
   } else {
-    name = v8::String::Concat(name, object->GetConstructorName());
+    name = v8::String::Concat(isolate, name, object->GetConstructorName());
   }
-  name = v8::String::Concat(name, v8::String::NewFromUtf8(isolate, "]"));
+  name =
+      v8::String::Concat(isolate, name, v8::String::NewFromUtf8(isolate, "]"));
 
   if (try_catch.HasCaught()) {
     return std::unique_ptr<base::Value>(

extensions/renderer/module_system.cc

@@ -109,9 +109,9 @@ void SetExportsProperty(
   v8::Local<v8::Object> obj = args.This();
   CHECK_EQ(2, args.Length());
   CHECK(args[0]->IsString());
-  v8::Maybe<bool> result =
-      obj->DefineOwnProperty(args.GetIsolate()->GetCurrentContext(),
-                             args[0]->ToString(), args[1], v8::ReadOnly);
+  v8::Maybe<bool> result = obj->DefineOwnProperty(
+      args.GetIsolate()->GetCurrentContext(),
+      args[0]->ToString(args.GetIsolate()), args[1], v8::ReadOnly);
   if (!result.FromMaybe(false))
     LOG(ERROR) << "Failed to set private property on the export.";
 }
@@ -656,8 +656,8 @@ v8::Local<v8::String> ModuleSystem::WrapSource(v8::Local<v8::String> source) {
       "$JSON, $Object, $RegExp, $String, $Error) {"
       "'use strict';");
   v8::Local<v8::String> right = ToV8StringUnsafe(GetIsolate(), "\n})");
-  return handle_scope.Escape(v8::Local<v8::String>(
-      v8::String::Concat(left, v8::String::Concat(source, right))));
+  return handle_scope.Escape(v8::Local<v8::String>(v8::String::Concat(
+      GetIsolate(), left, v8::String::Concat(GetIsolate(), source, right))));
 }
 
 void ModuleSystem::Private(const v8::FunctionCallbackInfo<v8::Value>& args) {

extensions/renderer/safe_builtins.cc

@@ -182,7 +182,8 @@ class ExtensionImpl : public v8::Extension {
     if (info[1]->IsObject()) {
       recv = v8::Local<v8::Object>::Cast(info[1]);
     } else if (info[1]->IsString()) {
-      recv = v8::StringObject::New(v8::Local<v8::String>::Cast(info[1]))
+      recv = v8::StringObject::New(info.GetIsolate(),
+                                   v8::Local<v8::String>::Cast(info[1]))
                  .As<v8::Object>();
     } else {
       info.GetIsolate()->ThrowException(

extensions/renderer/script_context.cc

@@ -428,7 +428,7 @@ std::string ScriptContext::GetStackTraceAsString() const {
   }
   std::string result;
   for (int i = 0; i < stack_trace->GetFrameCount(); ++i) {
-    v8::Local<v8::StackFrame> frame = stack_trace->GetFrame(i);
+    v8::Local<v8::StackFrame> frame = stack_trace->GetFrame(isolate(), i);
     CHECK(!frame.IsEmpty());
     result += base::StringPrintf(
         "\n    at %s (%s:%d:%d)",

third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc

@@ -131,7 +131,7 @@ class CaptureExportedStringFunction final : public ScriptFunction {
     v8::Local<v8::Value> exported_value =
         module_namespace->Get(context, V8String(isolate, export_name_))
             .ToLocalChecked();
-    captured_value_ = ToCoreString(exported_value->ToString());
+    captured_value_ = ToCoreString(exported_value->ToString(isolate));
 
     return ScriptValue();
   }
@@ -165,11 +165,11 @@ class CaptureErrorFunction final : public ScriptFunction {
 
     v8::Local<v8::Value> name =
         error_object->Get(context, V8String(isolate, "name")).ToLocalChecked();
-    name_ = ToCoreString(name->ToString());
+    name_ = ToCoreString(name->ToString(isolate));
     v8::Local<v8::Value> message =
         error_object->Get(context, V8String(isolate, "message"))
             .ToLocalChecked();
-    message_ = ToCoreString(message->ToString());
+    message_ = ToCoreString(message->ToString(isolate));
 
     return ScriptValue();
   }

third_party/blink/renderer/core/streams/readable_stream_operations_test.cc

@@ -62,7 +62,7 @@ class Iteration final : public GarbageCollectedFinalized<Iteration> {
       is_valid_ = false;
       return;
     }
-    value_ = ToCoreString(value->ToString());
+    value_ = ToCoreString(value->ToString(v.GetScriptState()->GetIsolate()));
   }
 
   bool IsSet() const { return is_set_; }

third_party/blink/renderer/core/testing/dictionary_test.cc

@@ -221,7 +221,7 @@ String DictionaryTest::stringFromIterable(
 
     v8::Local<v8::Value> value;
     if (iterator.GetValue().ToLocal(&value))
-      result.Append(ToCoreString(value->ToString()));
+      result.Append(ToCoreString(value->ToString(script_state->GetIsolate())));
   }
 
   return result.ToString();

third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.cc

@@ -12,9 +12,10 @@ void TraceWrapperV8String::Concat(v8::Isolate* isolate, const String& string) {
   DCHECK(isolate);
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::String> target_string =
-      (string_.IsEmpty()) ? V8String(isolate, string)
-                          : v8::String::Concat(string_.NewLocal(isolate),
-                                               V8String(isolate, string));
+      (string_.IsEmpty())
+          ? V8String(isolate, string)
+          : v8::String::Concat(isolate, string_.NewLocal(isolate),
+                               V8String(isolate, string));
   string_.Set(isolate, target_string);
 }