[LayoutNG] Not paint document marker on ellipsis.
This patch stops painting document markers on ellipsis character. Old implementation is bit strange : painting background of ellipsis as culled characters are not hided only for find-in-page marker. See: https://docs.google.com/document/d/1Osd-W9IMxHrrgJ2Kvo7HfpVTms7EDUbOHhsmL1c3_Yo/ This patch implements simply: do not paint any marker on ellipsis because characters are hide. That can cause a bit weird situation: if find-in-page hits such hide texts, it shows numbers of found texts but blink doesn't paint anything. However old implementation already has similar situation: if found text are clipped by text-overflow: clip, also blink doesn't show them. Thus this is acceptable change. This patch fixes following tests: paint/markers/ellipsis-ltr-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-ltr-text-in-rtl-flow-with-markers.html paint/markers/ellipsis-mixed-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-mixed-text-in-rtl-flow-with-markers.html paint/markers/ellipsis-rtl-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-rtl-text-in-rtl-flow-with-markers.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibdd7d485e2b5ac4b5db665d54b64131e6c1bcdb9 Reviewed-on: https://chromium-review.googlesource.com/1105681 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569152}
Showing
15.9 KB
15.8 KB
18.2 KB
18.6 KB
17.8 KB
16.8 KB