Commit 18204b61 authored by kylechar's avatar kylechar Committed by Commit Bot

Use base::BindOnce for PostTask callbacks.

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=creis@chromium.org

Bug: 714018
Change-Id: I45ef06c750df8d491227b7b7a8d9fdf233f06f04
Reviewed-on: https://chromium-review.googlesource.com/c/1475642
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633821}
parent fb6e5281
......@@ -242,7 +242,7 @@ void GinJavaBridgeDispatcherHost::SetAllowObjectContentsInspection(bool allow) {
if (!JavaBridgeThread::CurrentlyOn()) {
JavaBridgeThread::GetTaskRunner()->PostTask(
FROM_HERE,
base::Bind(
base::BindOnce(
&GinJavaBridgeDispatcherHost::SetAllowObjectContentsInspection,
this, allow));
return;
......
......@@ -65,7 +65,7 @@ void FlushProfilingData(base::Thread* thread) {
}
}
thread->task_runner()->PostDelayedTask(
FROM_HERE, base::Bind(&FlushProfilingData, thread),
FROM_HERE, base::BindOnce(&FlushProfilingData, thread),
base::TimeDelta::FromSeconds(flush_seconds));
}
......@@ -80,8 +80,8 @@ class ProfilingThreadControl {
return;
thread_ = new base::Thread("Profiling_Flush");
thread_->Start();
thread_->task_runner()->PostTask(FROM_HERE,
base::Bind(&FlushProfilingData, thread_));
thread_->task_runner()->PostTask(
FROM_HERE, base::BindOnce(&FlushProfilingData, thread_));
}
void Stop() {
......
......@@ -56,8 +56,9 @@ void StreamTextureProxy::BindToTaskRunner(
}
// Unretained is safe here only because the object is deleted on |loop_|
// thread.
task_runner->PostTask(FROM_HERE, base::Bind(&StreamTextureProxy::BindOnThread,
base::Unretained(this)));
task_runner->PostTask(FROM_HERE,
base::BindOnce(&StreamTextureProxy::BindOnThread,
base::Unretained(this)));
}
void StreamTextureProxy::BindOnThread() {
......
......@@ -127,8 +127,8 @@ void StreamTextureWrapperImpl::UpdateTextureSize(const gfx::Size& new_size) {
if (!main_task_runner_->BelongsToCurrentThread()) {
main_task_runner_->PostTask(
FROM_HERE, base::Bind(&StreamTextureWrapperImpl::UpdateTextureSize,
weak_factory_.GetWeakPtr(), new_size));
FROM_HERE, base::BindOnce(&StreamTextureWrapperImpl::UpdateTextureSize,
weak_factory_.GetWeakPtr(), new_size));
return;
}
......@@ -156,9 +156,10 @@ void StreamTextureWrapperImpl::Initialize(
natural_size_ = natural_size;
main_task_runner_->PostTask(
FROM_HERE, base::Bind(&StreamTextureWrapperImpl::InitializeOnMainThread,
weak_factory_.GetWeakPtr(), received_frame_cb,
media::BindToCurrentLoop(init_cb)));
FROM_HERE,
base::BindOnce(&StreamTextureWrapperImpl::InitializeOnMainThread,
weak_factory_.GetWeakPtr(), received_frame_cb,
media::BindToCurrentLoop(init_cb)));
}
void StreamTextureWrapperImpl::InitializeOnMainThread(
......@@ -187,8 +188,8 @@ void StreamTextureWrapperImpl::Destroy() {
// base::Unretained is safe here because this function is the only one that
// can call delete.
main_task_runner_->PostTask(
FROM_HERE,
base::Bind(&StreamTextureWrapperImpl::Destroy, base::Unretained(this)));
FROM_HERE, base::BindOnce(&StreamTextureWrapperImpl::Destroy,
base::Unretained(this)));
return;
}
......
......@@ -47,8 +47,8 @@ H264Encoder::H264Encoder(
H264Encoder::~H264Encoder() {
main_task_runner_->PostTask(
FROM_HERE,
base::Bind(&H264Encoder::ShutdownEncoder, base::Passed(&encoding_thread_),
base::Passed(&openh264_encoder_)));
base::BindOnce(&H264Encoder::ShutdownEncoder, std::move(encoding_thread_),
std::move(openh264_encoder_)));
}
void H264Encoder::EncodeOnEncodingTaskRunner(
......@@ -106,9 +106,10 @@ void H264Encoder::EncodeOnEncodingTaskRunner(
const bool is_key_frame = info.eFrameType == videoFrameTypeIDR;
origin_task_runner_->PostTask(
FROM_HERE, base::Bind(OnFrameEncodeCompleted, on_encoded_video_callback_,
video_params, base::Passed(&data), nullptr,
capture_timestamp, is_key_frame));
FROM_HERE,
base::BindOnce(OnFrameEncodeCompleted, on_encoded_video_callback_,
video_params, std::move(data), nullptr, capture_timestamp,
is_key_frame));
}
void H264Encoder::ConfigureEncoderOnEncodingTaskRunner(const gfx::Size& size) {
......
......@@ -5047,8 +5047,8 @@ void RenderFrameImpl::ShowContextMenu(const blink::WebContextMenuData& data) {
// javascript onselectionchanged is triggered.
// See crbug.com/729488
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&RenderFrameImpl::ShowDeferredContextMenu,
weak_factory_.GetWeakPtr(), params));
FROM_HERE, base::BindOnce(&RenderFrameImpl::ShowDeferredContextMenu,
weak_factory_.GetWeakPtr(), params));
#else
ShowDeferredContextMenu(params);
#endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment