Commit 182682f3 authored by Azeem Arshad's avatar Azeem Arshad Committed by Commit Bot

[Network Details] Add aria labels for manual proxy config input fields.

This CL adds aria labels for host and port input fields in manual proxy
configuration section in network details page. Also adds labels for
proxy exception input field.

Bug: 1024355
Change-Id: I0fe751e248b9f51916d83bb5ca7ae92ee14ac3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913097Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715121}
parent bf85a504
......@@ -2218,6 +2218,9 @@
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_USE_SAME" desc="Settings > Internet > Network details: Label for checkbox indicating that a network proxy uses the same value for all protocols.">
Use the same proxy for all protocols
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_INPUT_ACCESSIBILITY_LABEL" desc="Settings > Internet > Accessibility only label for input field to add proxy exceptions.">
Host or domain to exclude
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_LIST" desc="Settings > Internet > Network details: Label for list of network proxy exceptions.">
Do not use the proxy settings for these hosts and domains:
</message>
......@@ -2236,6 +2239,9 @@
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_PROXY" desc="Settings > Internet > Network details: Label for all proxies.">
Proxy
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_HOST_INPUT_ACCESSIBILITY_LABEL" desc="Settings > Internet > Network details: Accessibility only label for proxy host input field.">
<ph name="INPUT_LABEL">$1<ex>HTTP Proxy</ex></ph> - Host
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_HTTP_PROXY" desc="Settings > Internet > Network details: Label for HTTP proxy.">
HTTP Proxy
</message>
......@@ -2251,6 +2257,9 @@
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_PORT" desc="Settings > Internet > Network details: Label for proxy port input.">
Port
</message>
<message name="IDS_SETTINGS_INTERNET_NETWORK_PROXY_PORT_INPUT_ACCESSIBILITY_LABEL" desc="Settings > Internet > Network details: Accessibility only label for proxy port number input field.">
<ph name="INPUT_LABEL">$1<ex>HTTP Proxy</ex></ph> - Port
</message>
<!-- Settings > Internet > SIM lock/unlock dialog -->
<message name="IDS_SETTINGS_INTERNET_NETWORK_SIM_CHANGE_PIN" desc="Settings > Internet > Network details > Lock/unlock SIM card: Label for buton to change the PIN.">
......
......@@ -193,11 +193,17 @@ void AddDetailsLocalizedStrings(content::WebUIDataSource* html_source) {
IDS_SETTINGS_INTERNET_NETWORK_PROXY_CONNECTION_TYPE},
{"networkProxyEnforcedPolicy",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_ENFORCED_POLICY},
{"networkProxyExceptionInputA11yLabel",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_INPUT_ACCESSIBILITY_LABEL},
{"networkProxyExceptionList",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_EXCEPTION_LIST},
{"networkProxyFtp", IDS_SETTINGS_INTERNET_NETWORK_PROXY_FTP_PROXY},
{"networkProxyHostInputA11yLabel",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_HOST_INPUT_ACCESSIBILITY_LABEL},
{"networkProxyHttp", IDS_SETTINGS_INTERNET_NETWORK_PROXY_HTTP_PROXY},
{"networkProxyPort", IDS_SETTINGS_INTERNET_NETWORK_PROXY_PORT},
{"networkProxyPortInputA11yLabel",
IDS_SETTINGS_INTERNET_NETWORK_PROXY_PORT_INPUT_ACCESSIBILITY_LABEL},
{"networkProxyShttp", IDS_SETTINGS_INTERNET_NETWORK_PROXY_SHTTP_PROXY},
{"networkProxySocks", IDS_SETTINGS_INTERNET_NETWORK_PROXY_SOCKS_HOST},
{"networkProxyTypeDirect",
......
......@@ -131,6 +131,7 @@
</network-proxy-exclusions>
<div id="addException" class="layout horizontal center">
<cr-input id="proxyExclusion" class="flex"
aria-label="[[i18n('networkProxyExceptionInputA11yLabel')]]"
on-keypress="onAddProxyExclusionKeypress_">
<cr-button on-click="onAddProxyExclusionTap_" slot="suffix">
[[i18n('networkProxyAddException')]]
......
......@@ -33,10 +33,12 @@
<div id="container">
<div id="label">[[label]]</div>
<cr-input id="host" readonly="[[!editable]]"
aria-label="[[i18n('networkProxyHostInputA11yLabel', label)]]"
value="{{value.host.activeValue}}" on-change="onValueChange_">
</cr-input>
<div>[[i18n('networkProxyPort')]]</div>
<cr-input id="port" readonly="[[!editable]]"
aria-label="[[i18n('networkProxyPortInputA11yLabel', label)]]"
value="{{value.port.activeValue}}" on-change="onValueChange_">
</cr-input>
</div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment