GitLab

[search_provider] clean up unit test.

Cleanup: there is no logic changes in this CL.

I tried making an edit in this file and found there were many small
style issues*. These changes, done separately, can keep my other CL
cleaner:
- fix use of NULL instead of nullptr
- fix lines over 80 chars long
- fix 3 space indenting
- fix 1 space indent on eol comments
- fix use of assert true for comparison
- fix suggetion to suggestion

*Which create a big list of warnings, making it hard to see if I've
introduced new issues.

TBR=mpearson@chromium.org

Bug: None
Change-Id: I4252ea4c62f33ff201ee80179150c7f10b13084f
Reviewed-on: https://chromium-review.googlesource.com/996752
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548275}