Skip to content

GitLab

T
tangled
Commit 18399828 authored by David Grogan's avatar David Grogan Committed by Commit Bot
Browse files
Options

Add test asserting the display property of <details> is ignored 

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
https://github.com/whatwg/html/pull/3686

This scenario is discussed at the end of
https://github.com/whatwg/html/issues/603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
https://github.com/w3c/csswg-drafts/issues/2084
https://github.com/whatwg/html/issues/1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}
parent 43c7ee45
Hide whitespace changes
Inline Side-by-side
Showing with 47 additions and 0 deletions
third_party/WebKit/LayoutTests/external/wpt/html/rendering/the-details-element/details-display-property-is-ignored-ref.html 0 → 100644
View file @ 18399828
<!DOCTYPE html>
<meta charset="utf-8">
<link rel="author" title="David Grogan" href="dgrogan@chromium.org">
From <a href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements">html.spec.whatwg.org</a>:
<blockquote>
The details element is expected to render as a block box. The element's shadow
tree is expected to take the element's first summary element child, if any, and
place it in a first block box container, and then take the element's remaining
descendants, if any, and place them in a second block box container.
</blockquote>
&lt;details display:flex> should be ignored. Otherwise details would render as
something other than a block box.
<hr>
<details open>
<summary>This is the summary.</summary>
<div>thing 1</div>
thing 2
</details>
third_party/WebKit/LayoutTests/external/wpt/html/rendering/the-details-element/details-display-property-is-ignored.html 0 → 100644
View file @ 18399828
<!DOCTYPE html>
<meta charset="utf-8">
<link rel="author" title="David Grogan" href="dgrogan@chromium.org">
<link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements">
<link rel="match" href="details-display-property-is-ignored-ref.html">
<link rel="bookmark" href="https://bugs.chromium.org/p/chromium/issues/detail?id=635282" />
<meta name="assert" content="The display property is ignored on details elements and is instead always rendered as a block box." />
From <a href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements">html.spec.whatwg.org</a>:
<blockquote>
The details element is expected to render as a block box. The element's shadow
tree is expected to take the element's first summary element child, if any, and
place it in a first block box container, and then take the element's remaining
descendants, if any, and place them in a second block box container.
</blockquote>
&lt;details display:flex> should be ignored. Otherwise details would render as
something other than a block box.
<hr>
<details open style="display:flex;">
<summary>This is the summary.</summary>
<div>thing 1</div>
thing 2
</details>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment