Stop supporting -webkit-appearance:button for elements other than <button> and <input> buttons.

It was deprecated in M79.

I2DR: https://t.co/ngv1jxRKwk

Bug: 981720
Change-Id: I5c365aaaa65c66a4dccd7224e4ad5d482b6ad2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892971Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711657}

third_party/blink/renderer/core/layout/layout_theme.cc

@@ -206,9 +206,10 @@ ControlPart LayoutTheme::AdjustAppearanceWithElementType(
       // even if their default appearances are different from the keywords.
 
     case kButtonPart:
-      if (IsA<HTMLSelectElement>(*element) || IsA<HTMLAnchorElement>(*element))
-        return auto_appearance;
-      return part;
+      return (auto_appearance == kPushButtonPart ||
+              auto_appearance == kSquareButtonPart)
+                 ? part
+                 : auto_appearance;
 
     case kMenulistButtonPart:
       return auto_appearance == kMenulistPart ? part : auto_appearance;

third_party/blink/renderer/core/paint/box_paint_invalidator_test.cc

@@ -217,9 +217,6 @@ TEST_P(BoxPaintInvalidatorTest, ComputePaintInvalidationReasonOtherCases) {
   target.setAttribute(html_names::kStyleAttr, "box-shadow: inset 3px 2px");
   ExpectFullPaintInvalidationOnGeometryChange("With box-shadow");
 
-  target.setAttribute(html_names::kStyleAttr, "-webkit-appearance: button");
-  ExpectFullPaintInvalidationOnGeometryChange("With appearance");
-
   target.setAttribute(html_names::kStyleAttr,
                       "clip-path: circle(50% at 0 50%)");
   ExpectFullPaintInvalidationOnGeometryChange("With clip-path");

third_party/blink/renderer/core/paint/theme_painter.cc

@@ -147,6 +147,8 @@ bool ThemePainter::Paint(const LayoutObject& o,
   if (LayoutTheme::GetTheme().ShouldUseFallbackTheme(style))
     return PaintUsingFallbackTheme(node, style, paint_info, r);
 
+  // TODO(tkent): Clean the counting code when M80 is promoted to the stable
+  // channel.
   if (part == kButtonPart && node) {
     if (IsA<HTMLAnchorElement>(node)) {
       Deprecation::CountDeprecation(

third_party/blink/web_tests/fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt

-CONSOLE WARNING: '-webkit-appearance: button' for elements other than <button> and <input type=button/color/reset/submit> is deprecated and will be removed in M80, around February 2020. See https://www.chromestatus.com/features/4867142128238592 for more details.
 PASS, if no crash or assert in debug
 abc

third_party/blink/web_tests/fast/css/first-letter-inline-flow-split-table-crash-expected.txt

-CONSOLE WARNING: '-webkit-appearance: button' for elements other than <button> and <input type=button/color/reset/submit> is deprecated and will be removed in M80, around February 2020. See https://www.chromestatus.com/features/4867142128238592 for more details.
 PASS, if no exception or crash in debug

third_party/blink/web_tests/fast/css/relative-position-replaced-in-table-display-crash-expected.txt

-CONSOLE WARNING: '-webkit-appearance: button' for elements other than <button> and <input type=button/color/reset/submit> is deprecated and will be removed in M80, around February 2020. See https://www.chromestatus.com/features/4867142128238592 for more details.
 PASS, if no exception or crash in debug
  

third_party/blink/web_tests/fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt

-CONSOLE WARNING: '-webkit-appearance: button' for elements other than <button> and <input type=button/color/reset/submit> is deprecated and will be removed in M80, around February 2020. See https://www.chromestatus.com/features/4867142128238592 for more details.
 Bug 76842: Crash in WebCore::LayoutTableSection::rowLogicalHeightChanged
 
 This test passes if it does not crash nor ASSERT.

third_party/blink/web_tests/virtual/controls-refresh/color-scheme/button/button-appearance-basic-expected.txt

-CONSOLE WARNING: '-webkit-appearance: button' for elements other than <button> and <input type=button/color/reset/submit> is deprecated and will be removed in M80, around February 2020. See https://www.chromestatus.com/features/4867142128238592 for more details.