Commit 183d0666 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Update trivial TODOs

One TODO has already been addressed in
https://chromium-review.googlesource.com/c/chromium/src/+/1969582 and
the other TODO should be linked to a more appropriate bug.

Bug: None
Change-Id: Ib2b1da6f68c2dc43a9e892100864b5888cb6996b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992432
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730106}
parent 00512e0b
......@@ -112,8 +112,6 @@ void SyncErrorNotifier::Shutdown() {
void SyncErrorNotifier::OnStateChanged(syncer::SyncService* service) {
DCHECK_EQ(service, sync_service_);
// TODO(crbug.com/1019687): A sync error should also be prompted for
// sync_ui_util::ShouldShowSyncKeysMissingError().
const bool should_display_notification =
sync_ui_util::ShouldShowPassphraseError(sync_service_) ||
sync_ui_util::ShouldShowSyncKeysMissingError(sync_service_);
......
......@@ -115,7 +115,7 @@ IOSChromeSyncClient::IOSChromeSyncClient(ios::ChromeBrowserState* browser_state)
/*account_password_store=*/nullptr,
ios::BookmarkSyncServiceFactory::GetForBrowserState(browser_state_));
// TODO(crbug.com/1012660): Instantiate a specific client for ios.
// TODO(crbug.com/1019685): Instantiate a specific client for ios.
trusted_vault_client_ = std::make_unique<syncer::FileBasedTrustedVaultClient>(
browser_state_->GetStatePath().Append(kTrustedVaultFilename));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment