Commit 18535213 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix instances of bugprone-argument-comment

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: I06a90eb08ee7445e11f30409420ea5e1bef50aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459266Reviewed-by: default avatarNathan Parker <nparker@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815874}
parent 72d3e66b
...@@ -2290,81 +2290,81 @@ IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest, ...@@ -2290,81 +2290,81 @@ IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest, IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
VerifyNumberOfRecentNavigationsToCollect) { VerifyNumberOfRecentNavigationsToCollect) {
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/false, /*extended_reporting_enabled=*/false, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS)); SafeBrowsingNavigationObserverManager::SUCCESS));
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/true, /*extended_reporting_enabled=*/false, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS)); SafeBrowsingNavigationObserverManager::SUCCESS));
EXPECT_EQ(0, EXPECT_EQ(0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/false, /*extended_reporting_enabled=*/false, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE));
EXPECT_EQ(0, EXPECT_EQ(0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/true, /*extended_reporting_enabled=*/false, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE));
EXPECT_EQ( EXPECT_EQ(
0, CountOfRecentNavigationsToAppend( 0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/false, /*extended_reporting_enabled=*/false, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER));
EXPECT_EQ( EXPECT_EQ(
0, CountOfRecentNavigationsToAppend( 0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/true, /*extended_reporting_enabled=*/false, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER));
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/false, /*extended_reporting_enabled=*/false, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::INVALID_URL)); SafeBrowsingNavigationObserverManager::INVALID_URL));
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/true, /*extended_reporting_enabled=*/false, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::INVALID_URL)); SafeBrowsingNavigationObserverManager::INVALID_URL));
EXPECT_EQ( EXPECT_EQ(
0, 0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/false, /*extended_reporting_enabled=*/false, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND)); SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND));
EXPECT_EQ( EXPECT_EQ(
0, 0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/false, /*incognito=*/true, /*extended_reporting_enabled=*/false, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND)); SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND));
EXPECT_EQ(5, CountOfRecentNavigationsToAppend( EXPECT_EQ(5, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/false, /*extended_reporting_enabled=*/true, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS)); SafeBrowsingNavigationObserverManager::SUCCESS));
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/true, /*extended_reporting_enabled=*/true, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS)); SafeBrowsingNavigationObserverManager::SUCCESS));
EXPECT_EQ(5, EXPECT_EQ(5,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/false, /*extended_reporting_enabled=*/true, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE));
EXPECT_EQ(0, EXPECT_EQ(0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/true, /*extended_reporting_enabled=*/true, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_PAGE));
EXPECT_EQ( EXPECT_EQ(
0, CountOfRecentNavigationsToAppend( 0, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/false, /*extended_reporting_enabled=*/true, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER));
EXPECT_EQ( EXPECT_EQ(
0, CountOfRecentNavigationsToAppend( 0, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/true, /*extended_reporting_enabled=*/true, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER)); SafeBrowsingNavigationObserverManager::SUCCESS_LANDING_REFERRER));
EXPECT_EQ(5, CountOfRecentNavigationsToAppend( EXPECT_EQ(5, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/false, /*extended_reporting_enabled=*/true, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::INVALID_URL)); SafeBrowsingNavigationObserverManager::INVALID_URL));
EXPECT_EQ(0, CountOfRecentNavigationsToAppend( EXPECT_EQ(0, CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/true, /*extended_reporting_enabled=*/true, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::INVALID_URL)); SafeBrowsingNavigationObserverManager::INVALID_URL));
EXPECT_EQ( EXPECT_EQ(
5, 5,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/false, /*extended_reporting_enabled=*/true, /*is_incognito=*/false,
SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND)); SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND));
EXPECT_EQ( EXPECT_EQ(
0, 0,
CountOfRecentNavigationsToAppend( CountOfRecentNavigationsToAppend(
/*sber=*/true, /*incognito=*/true, /*extended_reporting_enabled=*/true, /*is_incognito=*/true,
SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND)); SafeBrowsingNavigationObserverManager::NAVIGATION_EVENT_NOT_FOUND));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment