Commit 18a6d85f authored by Xi Cheng's avatar Xi Cheng Committed by Commit Bot

Remove TODO in AvatarMenu::GetImageForMenuButton

Change-Id: Ie122cdd92aff2bdadddf1106018fc994fae81fdc
Reviewed-on: https://chromium-review.googlesource.com/c/1347099Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610470}
parent e3d82fc8
...@@ -29,16 +29,15 @@ AvatarMenu::ImageLoadStatus AvatarMenu::GetImageForMenuButton( ...@@ -29,16 +29,15 @@ AvatarMenu::ImageLoadStatus AvatarMenu::GetImageForMenuButton(
// If there is a Gaia image available, try to use that. // If there is a Gaia image available, try to use that.
if (entry->IsUsingGAIAPicture()) { if (entry->IsUsingGAIAPicture()) {
// TODO(chengx): The GetGAIAPicture API call will trigger an async image // The GetGAIAPicture API call will trigger an async image load from disk if
// load from disk if it has not been loaded. This is non-obvious and // it has not been loaded into memory.
// dependency should be avoided. We should come with a better idea to handle
// this.
const gfx::Image* gaia_image = entry->GetGAIAPicture(); const gfx::Image* gaia_image = entry->GetGAIAPicture();
if (gaia_image) { if (gaia_image) {
*image = *gaia_image; *image = *gaia_image;
return ImageLoadStatus::LOADED; return ImageLoadStatus::LOADED;
} }
if (entry->IsGAIAPictureLoaded()) if (entry->IsGAIAPictureLoaded())
status = ImageLoadStatus::MISSING; status = ImageLoadStatus::MISSING;
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment