Commit 18cfb8e0 authored by Tomasz Wiszkowski's avatar Tomasz Wiszkowski Committed by Commit Bot

Fix icons not tinting correctly on Android K.

ApiCompatibilityUtils.setImageTintList has correct support only for
- Android Lollipop and Above,
- AppCompatImageView class.
Any other imageview will seem to work, but will receive no tint.

Bug: 1038497
Change-Id: I7a7fcad80ff7b7ca3fb344448f27c5c093b25156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987266Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#728351}
parent 7dbf9517
......@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.omnibox.suggestions.base;
import android.content.Context;
import android.support.annotation.IdRes;
import android.support.v7.widget.AppCompatImageView;
import android.util.TypedValue;
import android.view.KeyEvent;
import android.view.LayoutInflater;
......@@ -54,7 +55,7 @@ public class BaseSuggestionView extends SimpleHorizontalLayoutView {
addView(mDecoratedView);
// Action icons. Currently we only support the Refine button.
mActionView = new ImageView(getContext());
mActionView = new AppCompatImageView(getContext());
mActionView.setBackgroundResource(selectableBackgroundRes);
mActionView.setClickable(true);
mActionView.setFocusable(true);
......
......@@ -21,6 +21,7 @@ import android.graphics.drawable.shapes.RoundRectShape;
import android.graphics.drawable.shapes.Shape;
import android.support.annotation.ColorInt;
import android.support.v4.view.ViewCompat;
import android.support.v7.widget.AppCompatImageView;
import android.util.AttributeSet;
import android.widget.ImageView;
......@@ -40,7 +41,7 @@ import androidx.annotation.Nullable;
* Note : This does not properly handle padding. Padding will not be taken into account when rounded
* corners are used.
*/
public class RoundedCornerImageView extends ImageView {
public class RoundedCornerImageView extends AppCompatImageView {
private final RectF mTmpRect = new RectF();
private final Matrix mTmpMatrix = new Matrix();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment